diff options
| author | Thomas Hackl <hackl@data-quest.de> | 2023-03-23 14:49:21 +0000 |
|---|---|---|
| committer | David Siegfried <david.siegfried@uni-vechta.de> | 2023-03-23 14:49:21 +0000 |
| commit | 3aecaab4d0387b063c9e02a3523eec4d9a70df4e (patch) | |
| tree | 3f861af53d15695253aedcbbf417aa73d4c47b12 /resources/assets/javascripts | |
| parent | 2a697c4ba43f5521c2c5348f25cb3254894ce91a (diff) | |
Resolve "Responsive Navigation: Aufklappen der Sidebar erfordert Scrollen an den Seitenanfang"
Closes #2360, #2337, #2318, and #2152
Merge request studip/studip!1587
Diffstat (limited to 'resources/assets/javascripts')
| -rw-r--r-- | resources/assets/javascripts/bootstrap/responsive.js | 2 | ||||
| -rw-r--r-- | resources/assets/javascripts/bootstrap/sidebar.js | 6 | ||||
| -rw-r--r-- | resources/assets/javascripts/entry-base.js | 1 | ||||
| -rw-r--r-- | resources/assets/javascripts/lib/sidebar.js | 15 |
4 files changed, 1 insertions, 23 deletions
diff --git a/resources/assets/javascripts/bootstrap/responsive.js b/resources/assets/javascripts/bootstrap/responsive.js index af06f28..7ee9b15 100644 --- a/resources/assets/javascripts/bootstrap/responsive.js +++ b/resources/assets/javascripts/bootstrap/responsive.js @@ -6,7 +6,7 @@ STUDIP.domReady(() => { document.documentElement.classList.add('fullscreen-mode'); const sidebar = document.getElementById('sidebar'); if (sidebar) { - sidebar.style.display = 'none'; + sidebar.ariaHidden = 'true'; } } diff --git a/resources/assets/javascripts/bootstrap/sidebar.js b/resources/assets/javascripts/bootstrap/sidebar.js deleted file mode 100644 index 04630c0..0000000 --- a/resources/assets/javascripts/bootstrap/sidebar.js +++ /dev/null @@ -1,6 +0,0 @@ -// Set correct sidebar height for stickyness -STUDIP.domReady(() => { - if (!STUDIP.Responsive.isResponsive()) { - STUDIP.Sidebar.adjustHeight(); - } -}); diff --git a/resources/assets/javascripts/entry-base.js b/resources/assets/javascripts/entry-base.js index f6f5595..70b78e7 100644 --- a/resources/assets/javascripts/entry-base.js +++ b/resources/assets/javascripts/entry-base.js @@ -28,7 +28,6 @@ import "./bootstrap/studip_helper_attributes.js" import "./bootstrap/header_magic.js" import "./bootstrap/header_navigation.js" import "./bootstrap/personal_notifications.js" -import "./bootstrap/sidebar.js" import "./bootstrap/dialog.js" import "./bootstrap/jsupdater.js" import "./bootstrap/files.js" diff --git a/resources/assets/javascripts/lib/sidebar.js b/resources/assets/javascripts/lib/sidebar.js index d3d67d5..3cb1c05 100644 --- a/resources/assets/javascripts/lib/sidebar.js +++ b/resources/assets/javascripts/lib/sidebar.js @@ -18,19 +18,4 @@ const Sidebar = { } }; -Sidebar.adjustHeight = () => { - const display = $('#sidebar').css('display'); - - if (display === 'none') { - $('#sidebar').css('display', 'block'); - } - const lastWidget = $('.sidebar-widget:last-child'); - if (lastWidget.length > 0) { - const height = lastWidget.offset().top + lastWidget.height(); - $('#sidebar').css('height', height + 'px'); - } - if (display === 'none') { - $('#sidebar').css('display', 'none'); - } -} export default Sidebar; |
