fix role loading for nobody, fixes #1209

Closes #1209

Merge request studip/studip!718

1 files changed, 10 insertions, 13 deletions

diff --git a/lib/plugins/db/RolePersistence.class.php b/lib/plugins/db/RolePersistence.class.php
index 60b0b65..d24c2a6 100644
--- a/lib/plugins/db/RolePersistence.class.php
+++ b/lib/plugins/db/RolePersistence.class.php
@@ -221,21 +221,18 @@ class RolePersistence
         $cache = self::getUserRolesCache();
 
         if (!isset($cache[$user_id])) {
-            $query = "SELECT DISTINCT *
-                      FROM (
-                          SELECT `roleid`, `institut_id`, 1 AS explicit
-                          FROM `roles_user`
-                          WHERE `userid` = :user_id
-
-                          UNION
-
-                          SELECT `roleid`, '' AS institut_id, 0 AS explicit
-                          FROM `roles_studipperms`
-                          WHERE `permname` = :perm
-                      ) AS tmp";
+            $query = "SELECT `roleid`, `institut_id`, 1 AS explicit
+                      FROM `roles_user`
+                      WHERE `userid` = :user_id
+
+                      UNION ALL
+
+                      SELECT `roleid`, '' AS institut_id, 0 AS explicit
+                      FROM `roles_studipperms`
+                      WHERE `permname` = :perm";
             $statement = DBManager::get()->prepare($query);
             $statement->bindValue(':user_id', $user_id);
-            $statement->bindValue(':perm', $GLOBALS['perm']->get_perm($user_id));
+            $statement->bindValue(':perm', is_object($GLOBALS['perm']) ? $GLOBALS['perm']->get_perm($user_id) : 'nobody');
             $statement->execute();
             $statement->setFetchMode(PDO::FETCH_ASSOC);