diff options
| author | Jan-Hendrik Willms <tleilax+studip@gmail.com> | 2024-09-27 11:50:34 +0000 |
|---|---|---|
| committer | David Siegfried <david.siegfried@uni-vechta.de> | 2024-09-27 11:50:34 +0000 |
| commit | 5f78b312c8ad82f91148d6bfe79c614651736161 (patch) | |
| tree | 43b1092303c8fd99a1cf1c1493da567bf8119eed /lib/models/ModuleManagementModel.php | |
| parent | 48ea0fdedeaa4b75e113a521d63682fed3881c4e (diff) | |
fix errors found through static code analysis, fixes #4562
Closes #4562
Merge request studip/studip!3375
Diffstat (limited to 'lib/models/ModuleManagementModel.php')
| -rw-r--r-- | lib/models/ModuleManagementModel.php | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/lib/models/ModuleManagementModel.php b/lib/models/ModuleManagementModel.php index 786b1e3..3bd5eb7 100644 --- a/lib/models/ModuleManagementModel.php +++ b/lib/models/ModuleManagementModel.php @@ -253,7 +253,6 @@ abstract class ModuleManagementModel extends SimpleORMap implements ModuleManage * Logs all changes of this object. * * @param string $action new, update or delete - * @return boolean Return true if logging was successful. */ protected function logChanges ($action = null) { @@ -367,7 +366,7 @@ abstract class ModuleManagementModel extends SimpleORMap implements ModuleManage $num_index = 1; break; default: - return false; + return; } if ($logging) { @@ -389,7 +388,7 @@ abstract class ModuleManagementModel extends SimpleORMap implements ModuleManage $debuginfo = $this->getDisplayName(); break; default: - return false; + return; } $id_array = $this->getId(); @@ -407,7 +406,7 @@ abstract class ModuleManagementModel extends SimpleORMap implements ModuleManage $debuginfo = $id_array[2]; break; default: - return false; + return; } if ($action == 'update') { @@ -424,9 +423,9 @@ abstract class ModuleManagementModel extends SimpleORMap implements ModuleManage StudipLog::log($logging, $aff, $coaff, $this->db_table(), $debuginfo); } - return true; + return; } - return false; + return; } /** @@ -927,7 +926,7 @@ abstract class ModuleManagementModel extends SimpleORMap implements ModuleManage */ protected static function formatDisplayName( string $template, - array $placeholders, + array $placeholders, array $replacements ): string { if (mb_strlen($template) === 0) { |