remove broken reimplementation of findTopFolder(), fixes #5944

Closes #5944

Merge request studip/studip!4545

1 files changed, 3 insertions, 2 deletions

diff --git a/lib/models/Courseware/StructuralElement.php b/lib/models/Courseware/StructuralElement.php
index d5cf5b5..e469454 100644
--- a/lib/models/Courseware/StructuralElement.php
+++ b/lib/models/Courseware/StructuralElement.php
@@ -2,6 +2,7 @@
 
 namespace Courseware;
 
+use Courseware\Filesystem\PublicFolder;
 use JSONArrayObject;
 use User;
 
@@ -978,9 +979,9 @@ SQL;
             $original_file_ref = \FileRef::find($this->image_id);
             if ($original_file_ref) {
                 $instance = new Instance($this->getCourseware($parent->range_id, $parent->range_type));
-                $folder = \Courseware\Filesystem\PublicFolder::findOrCreateTopFolder($instance);
+                $folder = \Folder::findTopFolder($instance->getRoot()->id, PublicFolder::class, 'courseware');
                 /** @var \FileRef $file_ref */
-                $file_ref = \FileManager::copyFile($original_file_ref->getFileType(), $folder, $user);
+                $file_ref = \FileManager::copyFile($original_file_ref->getFileType(), $folder->getTypedFolder(), $user);
                 $file_ref_id = $file_ref->id;
             }