fix for BIESt #1118

Merge request studip/studip!676

4 files changed, 4 insertions, 4 deletions

diff --git a/lib/extern/admin_extern.inc.php b/lib/extern/admin_extern.inc.php
index 0b6affe..fd436c4 100644
--- a/lib/extern/admin_extern.inc.php
+++ b/lib/extern/admin_extern.inc.php
@@ -315,7 +315,7 @@ else {
 }
 
 
-if (!$have_config) {
+if (empty($have_config)) {
     echo "<blockquote>\n";
     echo _("Es wurden noch keine Konfigurationen angelegt.");
     echo "</blockquote>";
diff --git a/lib/extern/lib/ExternConfig.class.php b/lib/extern/lib/ExternConfig.class.php
index 226dbe7..4c34625 100644
--- a/lib/extern/lib/ExternConfig.class.php
+++ b/lib/extern/lib/ExternConfig.class.php
@@ -121,7 +121,7 @@ class ExternConfig
     {
         foreach ($config as $element_name => $element) {
             if (is_array($element)) foreach ($element as $attribute => $value) {
-                if ((string)$value[0] == '|') {
+                if (!empty($value[0]) && (string)$value[0] == '|') {
                     $new_config[$element_name][$attribute] = explode('|', mb_substr($value, 1));
                 } else {
                     $new_config[$element_name][$attribute] = $value;
diff --git a/lib/extern/lib/ExternConfigDb.class.php b/lib/extern/lib/ExternConfigDb.class.php
index 1f23a86..c1ab29b 100644
--- a/lib/extern/lib/ExternConfigDb.class.php
+++ b/lib/extern/lib/ExternConfigDb.class.php
@@ -77,7 +77,7 @@ class ExternConfigDb extends ExternConfig
         if (!parent::insertConfiguration()) {
             return false;
         }
-         $serialized_config = json_encode($this->config);
+         $serialized_config = json_encode($this->config ?? null);
          $time = time();
          $query = "INSERT INTO extern_config VALUES (?, ?, ?, ?, 0, ?, ?, ?)";
          $statement = DBManager::get()->prepare($query);
diff --git a/lib/extern/views/extern_edit_module.inc.php b/lib/extern/views/extern_edit_module.inc.php
index 8c4bac4..21c5c88 100644
--- a/lib/extern/views/extern_edit_module.inc.php
+++ b/lib/extern/views/extern_edit_module.inc.php
@@ -145,7 +145,7 @@ if (Request::option('com') == 'store') {
 }
 
 
-if (!$edit_open[$edit]) {
+if (empty($edit_open[$edit])) {
     echo  LinkButton::create("<< " . _("Zurück"), URLHelper::getURL('?list=TRUE'));;
 }