fixes 'Method/function should return XY but return statement is missing', fixes #1278

Closes #1278

Merge request studip/studip!783

1 files changed, 8 insertions, 5 deletions

diff --git a/lib/classes/coursewizardsteps/AdvancedBasicDataWizardStep.php b/lib/classes/coursewizardsteps/AdvancedBasicDataWizardStep.php
index 595c5fe..780f837 100644
--- a/lib/classes/coursewizardsteps/AdvancedBasicDataWizardStep.php
+++ b/lib/classes/coursewizardsteps/AdvancedBasicDataWizardStep.php
@@ -39,13 +39,16 @@ class AdvancedBasicDataWizardStep extends BasicDataWizardStep
         $factory = new Flexi_TemplateFactory($GLOBALS['STUDIP_BASE_PATH'].'/app/views/course/wizard/steps');
         $template = $factory->open('advancedbasicdata/index');
 
-        if ($template = $this->setupTemplateAttributes($template, $values, $stepnumber, $temp_id)) {
-            $values = $this->makeI18N($values[__CLASS__], ['name', 'description', 'subtitle', 'kind']);
+        $template = $this->setupTemplateAttributes($template, $values, $stepnumber, $temp_id);
+        if (!$template) {
+            return '';
+        }
 
-            $template->set_attribute('values', array_merge($template->values, $values));
+        $values = $this->makeI18N($values[__CLASS__], ['name', 'description', 'subtitle', 'kind']);
 
-            return $template->render();
-        }
+        $template->set_attribute('values', array_merge($template->values, $values));
+
+        return $template->render();
     }
 
     /**