resurrect lost commit, fixes #1235

Closes #1235

Merge request studip/studip!806

1 files changed, 10 insertions, 10 deletions

diff --git a/lib/classes/UserLookup.class.php b/lib/classes/UserLookup.class.php
index cef2b4a..61732ae 100644
--- a/lib/classes/UserLookup.class.php
+++ b/lib/classes/UserLookup.class.php
@@ -231,20 +231,20 @@ class UserLookup
             throw new Exception('[UserLookup] Unknown type "' . $type . '"');
         }
 
-        if (self::USE_CACHE) {
-            $cache = StudipCacheFactory::getCache();
-            $cache_key = "UserLookup/{$type}/values";
-            $cached_values = $cache->read($cache_key);
-            if ($cached_values) {
-                return unserialize($cached_values);
-            }
+        if (!self::USE_CACHE) {
+            return call_user_func(self::$types[$type]['values']);
+        }
+
+        $cache = StudipCacheFactory::getCache();
+        $cache_key = "UserLookup/{$type}/values";
+        $cached_values = $cache->read($cache_key);
+        if ($cached_values) {
+            return unserialize($cached_values);
         }
 
         $values = call_user_func(self::$types[$type]['values']);
 
-        if (self::USE_CACHE) {
-            $cache->write($cache_key, serialize($values), self::CACHE_DURATION);
-        }
+        $cache->write($cache_key, serialize($values), self::CACHE_DURATION);
 
         return $values;
     }