diff options
| author | Jan-Hendrik Willms <tleilax+studip@gmail.com> | 2023-03-10 18:45:14 +0000 |
|---|---|---|
| committer | David Siegfried <david.siegfried@uni-vechta.de> | 2023-03-10 18:45:14 +0000 |
| commit | 01ebc410441ae59c684381c175217281c2d78edd (patch) | |
| tree | 75ae7153be87bfc53861abe13cee4ad9f2eab703 /lib/classes/MultiDimArrayObject.class.php | |
| parent | fef7d9367736f3b33b0318da237ab024841c4f3f (diff) | |
return type adjustments, fixes #2290
Closes #2290
Merge request studip/studip!1514
Diffstat (limited to 'lib/classes/MultiDimArrayObject.class.php')
| -rw-r--r-- | lib/classes/MultiDimArrayObject.class.php | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/lib/classes/MultiDimArrayObject.class.php b/lib/classes/MultiDimArrayObject.class.php index 8af74a7..459578f 100644 --- a/lib/classes/MultiDimArrayObject.class.php +++ b/lib/classes/MultiDimArrayObject.class.php @@ -80,7 +80,10 @@ class MultiDimArrayObject extends StudipArrayObject * Create a new iterator from an ArrayObject instance * * @return \Iterator + * + * @todo Add Traversable return type when Stud.IP requires PHP8 minimal */ + #[ReturnTypeWillChange] public function getIterator() { $class = $this->iteratorClass; @@ -94,7 +97,10 @@ class MultiDimArrayObject extends StudipArrayObject * @param mixed $key * @param mixed $value * @return void + * + * @todo Add void return type when Stud.IP requires PHP8 minimal */ + #[ReturnTypeWillChange] public function offsetSet($key, $value) { $new_value = $this->recursiveArrayToArrayObjects($value); @@ -103,9 +109,10 @@ class MultiDimArrayObject extends StudipArrayObject $new_value = new $class($new_value, $this->getFlags(), $this->getIteratorClass()); } if (is_null($key)) { - return $this->storage[] = $new_value; + $this->storage[] = $new_value; + } else { + $this->storage[$key] = $new_value; } - $this->storage[$key] = $new_value; } protected function recursiveArrayToArrayObjects($data) |