set allow_nobody the right way, fixes #6246

Closes #6246

Merge request studip/studip!4724

6 files changed, 31 insertions, 15 deletions

diff --git a/app/controllers/search/angebot.php b/app/controllers/search/angebot.php
index 4f749d4..b1ef49a 100644
--- a/app/controllers/search/angebot.php
+++ b/app/controllers/search/angebot.php
@@ -15,11 +15,15 @@
 
 class Search_AngebotController extends MVVController
 {
+    public function __construct(Trails\Dispatcher $dispatcher)
+    {
+        $this->allow_nobody = Config::get()->getValue('COURSE_SEARCH_IS_VISIBLE_NOBODY');
+
+        parent::__construct($dispatcher);
+    }
 
     public function before_filter(&$action, &$args)
     {
-        $this->allow_nobody = Config::get()->COURSE_SEARCH_IS_VISIBLE_NOBODY;
-
         parent::before_filter($action, $args);
 
         // set navigation
diff --git a/app/controllers/search/module.php b/app/controllers/search/module.php
index e772d1e..b624f72 100644
--- a/app/controllers/search/module.php
+++ b/app/controllers/search/module.php
@@ -19,10 +19,15 @@ class Search_ModuleController extends MVVController
 {
     private $drill_down_filter = [];
 
-    public function before_filter(&$action, &$args)
+    public function __construct(Trails\Dispatcher $dispatcher)
     {
-        $this->allow_nobody = Config::get()->COURSE_SEARCH_IS_VISIBLE_NOBODY;
+        $this->allow_nobody = Config::get()->getValue('COURSE_SEARCH_IS_VISIBLE_NOBODY');
+
+        parent::__construct($dispatcher);
+    }
 
+    public function before_filter(&$action, &$args)
+    {
         parent::before_filter($action, $args);
 
         $this->drill_down_type = Request::option('type');
diff --git a/app/controllers/search/stgtable.php b/app/controllers/search/stgtable.php
index f652977..8159a54 100644
--- a/app/controllers/search/stgtable.php
+++ b/app/controllers/search/stgtable.php
@@ -18,11 +18,15 @@ require_once dirname(__FILE__) . '/studiengaenge.php';
 
 class Search_StgtableController extends Search_StudiengaengeController
 {
+    public function __construct(Trails\Dispatcher $dispatcher)
+    {
+        $this->allow_nobody = Config::get()->getValue('COURSE_SEARCH_IS_VISIBLE_NOBODY');
+
+        parent::__construct($dispatcher);
+    }
 
     public function before_filter(&$action, &$args)
     {
-        $this->allow_nobody = Config::get()->COURSE_SEARCH_IS_VISIBLE_NOBODY;
-
         MVVController::before_filter($action, $args);
 
         // set navigation
diff --git a/app/controllers/search/studiengaenge.php b/app/controllers/search/studiengaenge.php
index 210f243..6882f6f 100644
--- a/app/controllers/search/studiengaenge.php
+++ b/app/controllers/search/studiengaenge.php
@@ -15,11 +15,15 @@
 
 class Search_StudiengaengeController extends MVVController
 {
+    public function __construct(Trails\Dispatcher $dispatcher)
+    {
+        $this->allow_nobody = Config::get()->getValue('COURSE_SEARCH_IS_VISIBLE_NOBODY');
+
+        parent::__construct($dispatcher);
+    }
 
     public function before_filter(&$action, &$args)
     {
-        $this->allow_nobody = Config::get()->COURSE_SEARCH_IS_VISIBLE_NOBODY;
-
         parent::before_filter($action, $args);
 
         // set navigation
diff --git a/app/controllers/shared/download.php b/app/controllers/shared/download.php
index 6e39998..1bb3920 100644
--- a/app/controllers/shared/download.php
+++ b/app/controllers/shared/download.php
@@ -1,11 +1,11 @@
 <?php
 class Shared_DownloadController extends AuthenticatedController
 {
-    public function before_filter(&$action, &$args)
+    public function __construct(Trails\Dispatcher $dispatcher)
     {
-        $this->allow_nobody = Config::get()->COURSE_SEARCH_IS_VISIBLE_NOBODY;
+        $this->allow_nobody = Config::get()->getValue('COURSE_SEARCH_IS_VISIBLE_NOBODY');
 
-        parent::before_filter($action, $args);
+        parent::__construct($dispatcher);
     }
 
     /**
diff --git a/app/controllers/shared/modul.php b/app/controllers/shared/modul.php
index ffcfdb7..abb1857 100644
--- a/app/controllers/shared/modul.php
+++ b/app/controllers/shared/modul.php
@@ -15,12 +15,11 @@
 
 class Shared_ModulController extends AuthenticatedController
 {
-
-    public function before_filter(&$action, &$args)
+    public function __construct(Trails\Dispatcher $dispatcher)
     {
-        $this->allow_nobody = Config::get()->COURSE_SEARCH_IS_VISIBLE_NOBODY;
+        $this->allow_nobody = Config::get()->getValue('COURSE_SEARCH_IS_VISIBLE_NOBODY');
 
-        parent::before_filter($action, $args);
+        parent::__construct($dispatcher);
     }
 
     public function overview_action($modul_id, $semester_id = null)