always update priority (to force consistency), fixes #5968

Closes #5968

Merge request studip/studip!4573

1 files changed, 13 insertions, 12 deletions

diff --git a/app/controllers/settings/statusgruppen.php b/app/controllers/settings/statusgruppen.php
index 789d0ca..9427986 100644
--- a/app/controllers/settings/statusgruppen.php
+++ b/app/controllers/settings/statusgruppen.php
@@ -284,19 +284,20 @@ class Settings_StatusgruppenController extends Settings_SettingsController
                 $changed                                = true;
             }
 
-            if ($changed) {
-                $query = "UPDATE user_inst
-                          SET priority = ?
-                          WHERE user_id = ? AND Institut_id = ?";
-                $statement = DBManager::get()->prepare($query);
+            $query = "UPDATE user_inst
+                      SET priority = ?
+                      WHERE user_id = ? AND Institut_id = ?";
+            $statement = DBManager::get()->prepare($query);
 
-                foreach ($priorities as $id => $priority) {
-                    $statement->execute([
-                        $priority,
-                        $this->user->user_id,
-                        $id,
-                    ]);
-                }
+            foreach ($priorities as $id => $priority) {
+                $statement->execute([
+                    $priority,
+                    $this->user->user_id,
+                    $id,
+                ]);
+            }
+
+            if ($changed) {
                 PageLayout::postSuccess(_('Reihenfolge wurde geändert'));
             }
         }