align open groups config for my courses and notifications, fixes #328

1 files changed, 5 insertions, 3 deletions

diff --git a/app/controllers/settings/notification.php b/app/controllers/settings/notification.php
index 1c2b198..12245f3 100644
--- a/app/controllers/settings/notification.php
+++ b/app/controllers/settings/notification.php
@@ -180,8 +180,10 @@ class Settings_NotificationController extends Settings_SettingsController
      */
     public function open_action($id)
     {
-        $open      = $this->config->MY_COURSES_OPEN_GROUPS;
-        $open[$id] = true;
+        $open = $this->config->MY_COURSES_OPEN_GROUPS;
+        if (!in_array($id, $open)) {
+            $open[] = $id;
+        }
         $this->config->store('MY_COURSES_OPEN_GROUPS', $open);
 
         $this->redirect('settings/notification');
@@ -195,7 +197,7 @@ class Settings_NotificationController extends Settings_SettingsController
     public function close_action($id)
     {
         $open = $this->config->MY_COURSES_OPEN_GROUPS;
-        unset($open[$id]);
+        $open = array_diff($open, [$id]);
         $this->config->store('MY_COURSES_OPEN_GROUPS', $open);
 
         $this->redirect('settings/notification');