fix access to request's course and add docblock, fixes #6259

Closes #6259

Merge request studip/studip!4736

2 files changed, 24 insertions, 4 deletions

diff --git a/locale/de/LC_MAILS/close_resource_request.php b/locale/de/LC_MAILS/close_resource_request.php
index 0a166d8..ce042ff 100644
--- a/locale/de/LC_MAILS/close_resource_request.php
+++ b/locale/de/LC_MAILS/close_resource_request.php
@@ -1,4 +1,14 @@
-Eine Anfrage <?= $request->course instanceof Course
+<?php
+/**
+ * @var ResourceRequest $request
+ * @var string $lecturer_names
+ * @var string $booked_rooms
+ * @var SeminarCycleDate[] $metadates
+ * @var CourseDate[]|SeminarCycleDate[] $single_dates
+ * @var ResourceBookingException[] $booked_time_intervals
+ */
+?>
+Eine Anfrage <?= $request->course
                ? 'für die Veranstaltung [' .$request->course->getFullName('number-name') . ']' . $request->course->getItemURL()
                : '' ?> wurde bearbeitet.
 
@@ -18,7 +28,7 @@ Gebuchte Räume: <?= $booked_rooms ?>
 Art der Anfrage: <?= $request->getTypeString() ?>
 
 
-Die folgenden Zeiträume wurden gebucht<?= $request->course->isToolActive('CoreSchedule')
+Die folgenden Zeiträume wurden gebucht<?= $request->course?->isToolActive(CoreSchedule::class)
                ? ' und im [Ablaufplan]' . str_replace( 'details/index', 'dates', $request->course->getItemURL()) . ' eingetragen'
                : '' ?>:
 <? foreach ($metadates as $metadate) : ?>
diff --git a/locale/en/LC_MAILS/close_resource_request.php b/locale/en/LC_MAILS/close_resource_request.php
index b1bbe4c..433abcd 100644
--- a/locale/en/LC_MAILS/close_resource_request.php
+++ b/locale/en/LC_MAILS/close_resource_request.php
@@ -1,4 +1,14 @@
-A request <?= $request->course instanceof Course
+<?php
+/**
+ * @var ResourceRequest $request
+ * @var string $lecturer_names
+ * @var string $booked_rooms
+ * @var SeminarCycleDate[] $metadates
+ * @var CourseDate[]|SeminarCycleDate[] $single_dates
+ * @var ResourceBookingException[] $booked_time_intervals
+ */
+?>
+A request <?= $request->course
             ? 'for the course [' .$request->course->getFullName('number-name') . ']' . $request->course->getItemURL()
             : '' ?> has been processed.
 
@@ -17,7 +27,7 @@ Booked rooms: <?= $booked_rooms ?>
 Request type: <?= $request->getTypeString() ?>
 
 
-The following time ranges have been booked<?= $request->course->isToolActive('CoreSchedule')
+The following time ranges have been booked<?= $request->course?->isToolActive(CoreSchedule::class)
                ? ' and added to [Schedule]' . str_replace( 'details/index', 'dates', $request->course->getItemURL())
                : '' ?>:
 <? foreach ($metadates as $metadate) : ?>