aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Hackl <hackl@data-quest.de>2022-10-28 10:42:30 +0000
committerThomas Hackl <hackl@data-quest.de>2022-10-28 10:42:30 +0000
commit364121ec2f6a18ec1b01c469a78ec728b469a2c7 (patch)
tree538f1968b6eea340e9155ff5938d5ea81ab39841
parenteaba32effa8871018ebced155ac1ea611f17d107 (diff)
Resolve "Sidebar-Suchwidget verwendet einen Link für das Zurücksetzen-Icon statt eines Buttons"
Closes #1719 Merge request studip/studip!1122
-rw-r--r--resources/assets/stylesheets/scss/sidebar.scss3
-rw-r--r--resources/vue/components/courseware/CoursewareSearchWidget.vue6
-rw-r--r--templates/sidebar/search-widget.php2
3 files changed, 6 insertions, 5 deletions
diff --git a/resources/assets/stylesheets/scss/sidebar.scss b/resources/assets/stylesheets/scss/sidebar.scss
index 5177034..51bb9c2 100644
--- a/resources/assets/stylesheets/scss/sidebar.scss
+++ b/resources/assets/stylesheets/scss/sidebar.scss
@@ -324,7 +324,7 @@ select.sidebar-selectlist {
width: 100%;
}
- button {
+ .submit-search {
background-color: $content-color-20;
border: 1px solid $base-color-60;
border-left-color: $light-gray-color-40;
@@ -336,6 +336,7 @@ select.sidebar-selectlist {
}
.reset-search {
+ background-color: transparent;
border: 1px solid $base-color-60;
border-left: 0;
border-right: 0;
diff --git a/resources/vue/components/courseware/CoursewareSearchWidget.vue b/resources/vue/components/courseware/CoursewareSearchWidget.vue
index 5a2469b..95f71f4 100644
--- a/resources/vue/components/courseware/CoursewareSearchWidget.vue
+++ b/resources/vue/components/courseware/CoursewareSearchWidget.vue
@@ -8,10 +8,10 @@
v-model="searchTerm"
:aria-label="$gettext('Geben Sie einen Suchbegriff mit mindestens 3 Zeichen ein.')"
/>
- <a v-if="searched" @click.prevent="setShowSearchResults(false)"
- class="reset-search">
+ <button v-if="searched" @click.prevent="setShowSearchResults(false)"
+ class="reset-search" :title="$gettext('Suche zurücksetzen')">
<studip-icon shape="decline" size="20"></studip-icon>
- </a>
+ </button>
<button
type="submit"
:value="$gettext('Suchen')"
diff --git a/templates/sidebar/search-widget.php b/templates/sidebar/search-widget.php
index df4a1dd..13d6bed 100644
--- a/templates/sidebar/search-widget.php
+++ b/templates/sidebar/search-widget.php
@@ -19,7 +19,7 @@
<?= arrayToHtmlAttributes($needle['attributes']) ?>>
<? endif; ?>
<? if ($reset_link): ?>
- <a class="reset-search" href="<?= $reset_link ?>" tabindex="0"
+ <a class="reset-search" href="<?= $reset_link ?>" tabindex="0" role="button"
title="<?= _('Suche zurücksetzen') ?>">
<?= Icon::create('decline')->asImg(20) ?>
</a>