diff options
| author | Matthew White <mehw.is.me@inventati.org> | 2021-10-21 00:02:21 +0200 |
|---|---|---|
| committer | Matthew White <mehw.is.me@inventati.org> | 2021-10-21 00:02:21 +0200 |
| commit | f9c3b0a959957a7cae3ad03a3156cb902cd68f9a (patch) | |
| tree | e0ae93bd111bf9c854f5e3540f1545dee672c80e /test | |
| parent | 2fea154c45ac2fc17a4cbe1741d6454760d87716 (diff) | |
basic-persp-window-prev-buffers: ert test window-prev-buffers
A dirty 'window-prev-buffers' may allow a perspective to pull in
buffers from other perspectives.
Till Emacs 27.2, 'delete-window' may update 'window-prev-buffers'
for all windows. This means that after 'persp-reset-windows' the
single window left may end up with a dirty 'window-prev-buffers',
unless 'switch-to-buffer-preserve-window-point' is nil.
Upstream commit 8f63f0078a23421eada97b4da51b9308b82532ce reverted
window/winner changes (Revert 0454bfd3313) in Emacs (bug#23621).
So, what said above should not apply any more after that commit,
and 'switch-to-buffer-preserve-window-point' could not be used."
Diffstat (limited to 'test')
| -rw-r--r-- | test/test-perspective.el | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/test/test-perspective.el b/test/test-perspective.el index c13ec49..6f44608 100644 --- a/test/test-perspective.el +++ b/test/test-perspective.el @@ -866,6 +866,43 @@ A non-existing buffer passed as argument should be discarded." ;; Forced cleanup when tests failed. (persp-test-kill-extra-buffers "*dummy*")) +(ert-deftest basic-persp-window-prev-buffers () + "Test if `window-prev-buffers' gets buffers of other perspectives. + +A dirty `window-prev-buffers' may allow a perspective to pull in +buffers from other perspectives. + +Till Emacs 27.2, `delete-window' may update `window-prev-buffers' +for all windows. This means that after `persp-reset-windows' the +single window left may end up with a dirty `window-prev-buffers', +unless `switch-to-buffer-preserve-window-point' is nil. + +Upstream commit 8f63f0078a23421eada97b4da51b9308b82532ce reverted +window/winner changes (Revert 0454bfd3313) in Emacs (bug#23621). +So, what said above should not apply any more after that commit, +and `switch-to-buffer-preserve-window-point' could not be used." + (should (get-buffer-create "*scratch*")) + (persp-test-kill-extra-buffers "*dummy*") + (persp-test-with-persp + (let (dummy-buffer scratch-buffer scratch-buffer-A) + (should (setq scratch-buffer (switch-to-buffer "*scratch*"))) + (should (setq dummy-buffer (switch-to-buffer "*dummy*"))) + (should-not (assq dummy-buffer (window-prev-buffers))) + (should (assq scratch-buffer (window-prev-buffers))) + (should (eq dummy-buffer (current-buffer))) + (persp-switch "A") + (persp-set-buffer "*dummy*") + (should (setq scratch-buffer-A (get-buffer "*scratch* (A)"))) + (should-not (assq scratch-buffer-A (window-prev-buffers))) + (should-not (assq scratch-buffer (window-prev-buffers))) + (should-not (assq dummy-buffer (window-prev-buffers))) + (should (eq scratch-buffer-A (current-buffer))) + (persp-switch "main") + (should-not (assq scratch-buffer-A (window-prev-buffers))) + (should-not (assq dummy-buffer (window-prev-buffers))) + (should (assq scratch-buffer (window-prev-buffers))) + (should (eq scratch-buffer (current-buffer)))))) + (ert-deftest basic-persp-switching () "Test switching buffers and perspectives. |