| Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
It defaults to "-Q" but users can instead use "-q", which is useful
if "site-start.el" contains essential settings. Also rename `BATCH'
to `EMACS_BATCH', add `EMACS_ORG' and `EMACS_INTR', and rework use
of related variables.
|
|
|
|
Almost always would it be better to use `match-string-no-properties'
instead of `match-string', but because the name of the former is
excruciatingly long for a function that one often wants to use in
tight spaces and because it usually "does not really matter", I
usually went for the latter.
The problem is, it does matter. For example, even strings that are
usually only used by code may end up obfuscating debug statements.
So let's start doing the right thing, even though there surely will
be people frowning at the use of a shorthand.
The fake ("match-string" "match-string") shorthand is necessary to
protect literal `match-string' and `match-string-no-properties' from
being corrupted by interpreted as shorthand for the non-existent
`match-stringing' and `match-string-no-propertiesing'.
Unfortunately the shorthands have to be specified in each library
individually. Using "dir-locals.el" only works if the libraries
are compiled. At least this additional noise is neatly tucked away
at the end of the files.
It might turn out that out of the more than two hundred instances
where this replaces `match-string' with `match-string-no-properties'
we should have stuck with the former in an instance or two. That's
the price of progress and can be fixed once such regressions are
reported.
|
|
If we wrap an included group that leads to surprising coordinates
when addressing groups/suffixes in the menu.
|
|
|
|
In one case use lambda and in another pcase-lambda, not ##.
|
|
|
|
|
|
|
|
`magit-with-test-directory' adds "GIT_AUTHOR_NAME" and
"GIT_AUTHOR_EMAIL" to the environment, but these are not used for
the committer information.
No environment variables exist, which set both the author and
committer information. Additionally using "GIT_COMMITTER_NAME" and
"GIT_COMMITTER_EMAIL" would be an option. However, config variables
that set author and committer information in one go do exit. So set
"user.name" and "user.email" using the "-c" argument.
|
|
|
|
Move them next to the related tests. These tests were added in
[1: 3098bf68f2], and while it is true that they test a function
which is also implemented using libgit2, that implementation is
not by default so putting them in a section titled "libgit" is
misleading. We are not testing the embryonic and unused libgit2
implementation.
1: 2021-04-28 3098bf68f258e088ac0d3307398d99d8c2edba41
Add tests for `magit-bare-repo-p'
|
|
These changes have been made to libraries over time, but because test
files are not library, the tools that were used to make these changes
to libraries, skipped this file.
|
|
Basic UI tests; would catch the bug in commit 1ab107a7.
|
|
Yet another attempt to get this working on my machine
just failed and I do not see myself trying again.
|
|
This patch centralises the generation of ellipses by extending the
functionality provided by `magit-ellipsis`, allowing end users to
customise for instance the ellipsis used in `magit-log` buffers.
See [0] for more background and extra information.
[0] https://github.com/magit/magit/discussions/4907
|
|
|
|
|
|
|
|
Under Git v2.38.1, the magit-get and magit-toplevel:submodule tests
fail due to clone errors. Both of these tests add a submodule with a
_local_ URL. As of a1d4f67c12 (transport: make `protocol.file.allow`
be "user" by default, 2022-10-01) [*], Git prevents submodule
initialization from "file://" (and bare local) sources by default for
security reasons.
In the context of Magit's test suite, this isn't a security risk, so
teach magit-with-test-directory to add the file protocol to the list
of allowed protocols.
[*] This commit was brought into Git's maint-* branches for v2.30.X
through 2.38.X.
|
|
See #4798.
|
|
Don't hard code the "~" prefix because sourcehut plans to use a
different prefix for organizations.
Closes #4753.
|
|
This patch adds a new item to the default value of
`magit-clone-name-alist' so Magit knows about Sourcehut. The default
value of `magit-clone-url-format' has to be also changed to
accommodate the URL scheme used by Sourcehut which differs from the
ones provided by Github and Gitlab.
|
|
Like for cond et al.
|
|
This patch permits `magit-clone-url-format' to be represented as an
alist mapping hostnames to URL formats. This way Magit can be
configured to translate repository names into URLs when using servers
that employ different URL schemes. The current value type (string) is
kept for backwards compatibility.
|
|
The set of files that contain non-ASCII characters has grown since
1c6205d8 (Only set coding system for libraries that need it,
2016-12-27). Set the coding system for all files listed by
git grep -lP '[^\x00-\x7f]' '*.el'
Closes #4732.
|
|
|
|
|
|
I've been doing that for a long time for many of my other packages
and nobody reported an issue, but if someone is trying to build magit
by running make in a terminal running inside emacs and that uses bash
4.3 or older, then that would fail now. On the other hand more people
likely try "EMACS=emacs-26.1 make" and then wonder why that doesn't
work. (The new variable for indicating to a shell that it is running
inside emacs is INSIDE_EMACS.)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|