| Age | Commit message (Collapse) | Author |
|---|
|
|
|
The previous implementation kept breaking and we got no help fixing
that. More or less go back to the previous implementation, which we
know how to keep running without any outside help.
Previously testing using libgit was disabled because it was broken,
while now there simply isn't any code to attempt to test that.
|
|
Replace the `setup-emacs' GitHub action with a custom Nix install
(defined in t/default.nix) that bundles Emacsen with libegit and
its other dependencies.
|
|
Add simple tests for `magit-bare-repo-p', which is implemented with
both Git and libgit.
|
|
Expand symlinks in the test directory created by the
`magit-with-test-directory' macro. This ensures that path comparisons
with results from `magit-toplevel', which itself expands symlinks,
work as expected.
|
|
|
|
For me `shell-file-name' is "/bin/bash" and it freezes on
me for unknown reasons. If available use "/bin/sh" instead.
Closes #4176.
|
|
Use it to add the font-lock-face property, instead of the face
property.
|
|
|
|
See also [1] which discusses the same fix for magit-get.
[1]: https://github.com/magit/magit/pull/2743#issuecomment-242935014
|
|
|
|
|
|
456a77d3 (magit-tests.el: require tramp, 2017-07-02) seems to be
sufficient to get tests passing locally, but Travis still fails.
The same with-editor.el commit that removed "(require 'tramp)" also
removed "(require 'tramp-sh nil t)"; loading tramp-sh in the tests
fixes the Travis builds.
Note that we no longer need to use the NOERROR argument when loading
tramp-sh because tramp-sh is present in Emacs 24.4, our minimum Emacs
version.
|
|
`with-editor.el' no longer explicitly requires `tramp' upfront,
so we have to do that here now.
|
|
Temporarily override the tramp method so it just uses a plain shell
instead.
|
|
|
|
If magit--refresh-cache is activated, cache all config values at once.
Add tests for known tricky cases.
|
|
Let-binding process-environment does not nessarily protect from changes
made by setenv, because setenv may destructively modify the list object.
|
|
|
|
Replace `magit-insert-{unpulled,unpushed}-commits' with
`magit-insert-{unpulled-from,unpushed-to}-{upstream,pushremote}'.
Likewise replace `magit-jump-to-{unpulled,unpushed}' with
`magit-jump-to-{unpulled-from,unpushed-to}-{upstream,pushremote}'.
Also add `magit-get-tracked-remote'.
|
|
Add new option `magit-process-find-password-functions' and advertise
adding `magit-process-password-auth-sources' to its value, but do not
actually do so.
We don't use that function by default, because most users will be
unaware of this functionality and that might cause issues. For example
a user may have configured `auth-source' at some point, and then stopped
using it and also changed the password without also changing it in the
source used by `auth-source'. In such a case `auth-source' would return
the wrong password and that would then be feed to git. The user likely
would not note that this is what is happening and report a Magit defect.
|
|
When git asks the user for a password, this patch first asks the auth-source library. If no password is found, prompt the user.
|
|
Also add entry to release notes and a comment in the tests.
|
|
The idea is to only follow symlinks if absolutely necessary. The
previous implementation was broken in that it usually failed when
a symlink to some sub-directory of a repository was involved (and
when that succeeded, then only by accident).
This issue was reported in #2135. A previous attempt (#2209)
failed to address this issue, as it caused other cases to fail.
|
|
In chroots and other test environments these variables might be set to
values that cause Git to error out, so explicitly set dummy values.
Keep the equivalent configuration in .travis because Travis does unset
these (or all?) variables.
|
|
This reverts commit fd688cb2192393a18c28ff3b92d5a01634b1779e.
|
|
Also add a test for this function.
Fixes #2135.
|
|
|
|
|
|
At the beginning of library headers use
;; Copyright (C) YEARS The Magit Project Contributors
instead of
;; Copyright (C) YEARS The Magit Project Developers
"Developers" might be read as to imply that only the core team hold the
copyright. But that is not the case, since nobody assigned their rights
to us. Everyone who ever contributed holds the copyright for their
contribution(s).
|
|
|
|
Since we now use a subdirectory for documenation,
we might as well do the same for tests.
|
