| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fixes #2492.
|
|
|
|
Catched by ispell and ispell-comments-and-strings.
|
|
Fix the code-path used when the `with-editor-sleeping-editor' is used.
`shell-command' does not return the process as previously assumed, so
we have to `get-buffer-process' from the OUTPUT-BUFFER.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Most importantly depend on a snapshot of `dash', because *any* snapshot
is larger than 2.MM.S but we really do need v2.8 at the very least (for
`-let'). Actually depend on a snapshot corresponding to v2.12.1 because
that fixes magnars/dash.el#130.
|
|
|
|
This avoids throwing an error when trying emacsclientw.exe which
displays output in popup dialog boxes instead of stdout.
|
|
This is required if there are paths with-editor-emacsclient-path that
are not on exec-path.
|
|
|
|
Only shell-quote when passing things to shell: i.e. in the `with-editor'
macro.
|
|
|
|
Save the window configuration in the `with-editor' advice to
`server-switch-buffer', but only if `with-editor-mode' is enabled.
Previously saving the window configuration was left to callers, but
by the time they got a change to do so, it was already to late, as
the client buffer was already being displayed. Also we only did
this for committing but not rebasing.
Fixes #2273.
|
|
|
|
|
|
|
|
Where previously the function `buffer-file-name' was called without an
argument, instead just use the variable by the same name. Now this is
done consistently across the code base.
|
|
Fixes #2217.
|
|
This fixes #2197. We don't actually want to show the buffer belonging
to another client, so we call `server-done' instead of `server-edit'.
The latter calls the former and then also tries to select a buffer,
using `server-switch-buffer' which favors buffers belonging to another
client. This does matter when Emacs was started in daemon mode and the
user connects to the instance using the emacsclient and then uses Magit
to invoke. When s/he then completes the commit, then their always is
another client, the one used to connect to the instance in the first
place.
Later in `with-editor-return' we restore the window configuration from
before `with-editor' was used, so one would think that needlessly
showing another buffer before restoring the window configuration would
not matter. However the previous window configuration has to be
explicitly stored by the caller of `with-editor', so we cannot rely on
a configuration being stored and have to fix the above issue anyway.
In the case of committing using Magit this should not have made a
difference because that does save the previous window configuration, but
unfortunately it does it to late, when the configuration has already
been modified somewhat. I am not sure if that can be fixed, but in any
case that's a different issue.
|
|
|
|
|
|
Re #2198.
|
|
|
|
|
|
Also see #2156 and 2.2.0.txt.
|
|
|
|
When `package.el' is used to update a package whose libraries have
already been loaded in the current session, then parts of the loaded
version can leak into the new version during byte-compilation.
This can be avoided by compiling the libraries in a separate Emacs
instance. The library `async-bytecomp', which is part of the package
`async', does just that by advising the function `package--compile'.
So add `async' as an Elpa dependency, soft-require `async-bytecomp', and
if that succeeds, then turn on `async-bytecomp-package-mode' to activate
the advice. Because it is undefined which package is updated first, and
which library is loaded first, we have to this in both possible
candidates `with-editor' and `magit-popup'.
Users may update `magit' without updating the dependencies, so we have
to further force the updates of all the Elpa packages that are build
from the Melpa repository. To do so we depend on "20150808" snapshot
versions instead of "2.2.0".
When installing Magit manually, then `async-bytecomp' is not required,
because Magit is then compiled using the Makefile which already uses a
separate, untainted Emacs instance.
|
|
|
|
Improve the library summaries of the libraries that are distributed as
separate packages, as well as the summary and commentary of `magit.el'.
|
|
Note that emacs-24.4 implies cl-lib.
|
|
At the beginning of library headers use
;; Copyright (C) YEARS The Magit Project Contributors
instead of
;; Copyright (C) YEARS The Magit Project Developers
"Developers" might be read as to imply that only the core team hold the
copyright. But that is not the case, since nobody assigned their rights
to us. Everyone who ever contributed holds the copyright for their
contribution(s).
|
|
and move AUTHORS.md to the Documentation/ subdirectory. This also
requires extensive changes to the Makefiles and some libraries.
|
