aboutsummaryrefslogtreecommitdiff
path: root/lisp/magit-notes.el
AgeCommit message (Collapse)Author
2026-03-29Make Cond-Let's when$ availableJonas Bernoulli
2026-01-01Bump copyright yearsJonas Bernoulli
2025-11-05Drop a space from autoload cookiesJonas Bernoulli
The space (if any) between the keyword and form is not stripped when inserting the form into the autoloads file, which looks odd. In Emacs the number of autoload cookies with and without such a space, is almost the same, so that provides no guidance as to what should be preferred. Go with what makes the aligner in me happy.
2025-08-22Use Cond-Let's implementation of and-letJonas Bernoulli
Using the "other elements of VARLIST have access to SYMBOLs from earlier elements" variant is IMHO _wrong_ when there are in fact no other elements.
2025-08-22Use Cond-Let's implementations of {if,when,and,while}-let{,*}Jonas Bernoulli
Cond-Let's `if-let', `if-let*', `when-let', `when-let*' and `and-let*' implementations behave differently from the built-in implementations, but because I have been careful not to depend on the idiosyncrasies, switching over should be mostly safe. Also add shorthands for the other `cond-let--...' macros. We will start using those (and `cond-let' and `cond-let*') in later commits.
2025-08-01magit-notes-read-ref: Require a matchJonas Bernoulli
2025-08-01magit-notes-read-ref: Make two arguments optionalJonas Bernoulli
2025-07-25Use shorthand match-str instead of match-string-no-propertiesJonas Bernoulli
Almost always would it be better to use `match-string-no-properties' instead of `match-string', but because the name of the former is excruciatingly long for a function that one often wants to use in tight spaces and because it usually "does not really matter", I usually went for the latter. The problem is, it does matter. For example, even strings that are usually only used by code may end up obfuscating debug statements. So let's start doing the right thing, even though there surely will be people frowning at the use of a shorthand. The fake ("match-string" "match-string") shorthand is necessary to protect literal `match-string' and `match-string-no-properties' from being corrupted by interpreted as shorthand for the non-existent `match-stringing' and `match-string-no-propertiesing'. Unfortunately the shorthands have to be specified in each library individually. Using "dir-locals.el" only works if the libraries are compiled. At least this additional noise is neatly tucked away at the end of the files. It might turn out that out of the more than two hundred instances where this replaces `match-string' with `match-string-no-properties' we should have stuck with the former in an instance or two. That's the price of progress and can be fixed once such regressions are reported.
2025-02-02Use ## and seq-find instead of --firstJonas Bernoulli
In one case use lambda and in another pcase-lambda, not ##.
2025-01-01Bump copyright yearsJonas Bernoulli
2024-04-15Update contact informationJonas Bernoulli
2024-01-01Bump copyright yearsJonas Bernoulli
2023-08-14Address 'safe' XR/Relint regexp linter warningsBasil L. Contovounesios
These changes should either be equivalent to the old regexps, or clearly correct internal shortcomings of theirs. - Fix gratuitous or insufficient backslash escaping. In '[\[]' it is merely redundant, but in '[\\+]' it matches a literal backslash in addition to a plus. - Prefer \`..\' over ^..$ anchors in file name contexts.
2023-03-17Deprecate magit-git-dir to avoid needlessly repeating workJonas Bernoulli
Five years ago in [1: 5f407a29ac] we took the first step toward this. 1: 2018-10-15 5f407a29ac63b338c3c75e30b4633b44d5745036 magit-gitdir: New function Previously we cached the wrong thing. `expand-file-name' is cheap but "git rev-parse --git-dir" is not. Because `magit-git-dir' is where we cached, rev-parse was still needlessly called multiple times with the same arguments during a refresh. The effect should be most noticeable during a rebase.
2023-01-03Bump copyright yearsJonas Bernoulli
2022-04-22Refresh library headersJonas Bernoulli
2022-04-22Use and-let* for side-effectsJonas Bernoulli
2022-03-28Function-quote many more functionsJonas Bernoulli
2022-02-27magit-global-core.{notes,display}Ref: Actually handle global valueJonas Bernoulli
2022-01-01Bump copyright yearsJonas Bernoulli
2021-07-06magit-notes-read-refs: Support use as transient readerJonas Bernoulli
Some suffixes already try to use it, which resulted in an error.
2021-06-15Fix indentationJonas Bernoulli
2021-05-25Add SPDX-License-Identifier library headerJonas Bernoulli
2021-04-04magit-notes:--ref: Fix descriptionKyle Meyer
Restore description lost in ad55ecb8 (magit-notes:--ref: Define option explicitly, 2019-02-04).
2021-01-03Bump copyright yearsJonas Bernoulli
2020-05-16Adjust to renamed Transient macros and variablesJonas Bernoulli
2020-01-02Update copyright yearsJonas Bernoulli
2019-02-14[key] magit-notes:--ref: Bind -r (no shortarg)Jonas Bernoulli
2019-02-14[key] magit-{merge,notes}:--strategy: Bind shortarg if availableJonas Bernoulli
* In `magit-merge' and `magit-notes' bind "-s" instead of "=s". Bindings for options no longer have to begin with "=" and "-s" is the short argument for "--strategy" for "git-merge" and "git-notes". * In `magit-cherry-pick' and `magit-revert' continue to bind "=s" because for "git-cherry-pick" and "git-revert" "-s" is the short argument for "--signoff". Consistency would be nice but using the short argument when possible is more important. Also note that the valid values for "--strategy" differ from command to command, which is why we cannot use a shared infix argument.
2019-02-14magit-notes:--ref: Define option explicitlyJonas Bernoulli
2019-02-14magit-{merge,notes}:--strategy: Define options explicitlyJonas Bernoulli
2019-02-14Use same suffix section for switches and optionsJonas Bernoulli
Magit-Popup used separate sections for switches and options. Transient doesn't have that limitation.
2019-02-14Define magit-notes as a transient commandJonas Bernoulli
2019-01-02Bump copyright yearsJonas Bernoulli
2018-10-21In all libraries, put provide form into separate sectionJonas Bernoulli
2018-01-07Bump copyright yearsJonas Bernoulli
2017-11-21magit-notes-popup: display relevant variablesJonas Bernoulli
Show the global values in addition to the local values. Remove the old commands that were used to set these variables with new commands that are consistent with the respective commands used in other popup. Closes #2857.
2017-10-20Fix man page pastoAlexander Gramiak
2017-10-18magit-notes-read-args: on a stash default to thatJonas Bernoulli
Closes #3212.
2017-05-28magit-notes-merge: fix doc-string typosKyle Meyer
2017-01-04Bump copyright yearsJonas Bernoulli
2016-12-27magit-notes.el: new libraryJonas Bernoulli