| Age | Commit message (Collapse) | Author |
|
|
|
|
|
The space (if any) between the keyword and form is not stripped
when inserting the form into the autoloads file, which looks odd.
In Emacs the number of autoload cookies with and without such a
space, is almost the same, so that provides no guidance as to what
should be preferred. Go with what makes the aligner in me happy.
|
|
Using the "other elements of VARLIST have access to SYMBOLs from
earlier elements" variant is IMHO _wrong_ when there are in fact
no other elements.
|
|
Cond-Let's `if-let', `if-let*', `when-let', `when-let*' and `and-let*'
implementations behave differently from the built-in implementations,
but because I have been careful not to depend on the idiosyncrasies,
switching over should be mostly safe.
Also add shorthands for the other `cond-let--...' macros. We will
start using those (and `cond-let' and `cond-let*') in later commits.
|
|
|
|
|
|
Almost always would it be better to use `match-string-no-properties'
instead of `match-string', but because the name of the former is
excruciatingly long for a function that one often wants to use in
tight spaces and because it usually "does not really matter", I
usually went for the latter.
The problem is, it does matter. For example, even strings that are
usually only used by code may end up obfuscating debug statements.
So let's start doing the right thing, even though there surely will
be people frowning at the use of a shorthand.
The fake ("match-string" "match-string") shorthand is necessary to
protect literal `match-string' and `match-string-no-properties' from
being corrupted by interpreted as shorthand for the non-existent
`match-stringing' and `match-string-no-propertiesing'.
Unfortunately the shorthands have to be specified in each library
individually. Using "dir-locals.el" only works if the libraries
are compiled. At least this additional noise is neatly tucked away
at the end of the files.
It might turn out that out of the more than two hundred instances
where this replaces `match-string' with `match-string-no-properties'
we should have stuck with the former in an instance or two. That's
the price of progress and can be fixed once such regressions are
reported.
|
|
In one case use lambda and in another pcase-lambda, not ##.
|
|
|
|
|
|
|
|
These changes should either be equivalent to the old regexps,
or clearly correct internal shortcomings of theirs.
- Fix gratuitous or insufficient backslash escaping.
In '[\[]' it is merely redundant, but in '[\\+]' it matches a
literal backslash in addition to a plus.
- Prefer \`..\' over ^..$ anchors in file name contexts.
|
|
Five years ago in [1: 5f407a29ac] we took the first step toward this.
1: 2018-10-15 5f407a29ac63b338c3c75e30b4633b44d5745036
magit-gitdir: New function
Previously we cached the wrong thing. `expand-file-name' is cheap but
"git rev-parse --git-dir" is not. Because `magit-git-dir' is where we
cached, rev-parse was still needlessly called multiple times with the
same arguments during a refresh. The effect should be most noticeable
during a rebase.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Some suffixes already try to use it, which resulted in an error.
|
|
|
|
|
|
Restore description lost in ad55ecb8 (magit-notes:--ref: Define option
explicitly, 2019-02-04).
|
|
|
|
|
|
|
|
|
|
* In `magit-merge' and `magit-notes' bind "-s" instead of "=s".
Bindings for options no longer have to begin with "=" and "-s" is
the short argument for "--strategy" for "git-merge" and "git-notes".
* In `magit-cherry-pick' and `magit-revert' continue to bind "=s"
because for "git-cherry-pick" and "git-revert" "-s" is the short
argument for "--signoff".
Consistency would be nice but using the short argument when possible
is more important.
Also note that the valid values for "--strategy" differ from command
to command, which is why we cannot use a shared infix argument.
|
|
|
|
|
|
Magit-Popup used separate sections for switches and options.
Transient doesn't have that limitation.
|
|
|
|
|
|
|
|
|
|
Show the global values in addition to the local values.
Remove the old commands that were used to set these variables with
new commands that are consistent with the respective commands used
in other popup.
Closes #2857.
|
|
|
|
Closes #3212.
|
|
|
|
|
|
|