| Age | Commit message (Collapse) | Author |
|---|
|
Only augment the predicate if there actually is one.
Fix problem introduced in d527f833.
|
|
The former is better at taking ignore rules into account.
Remove the recently added `magit--untracked-files', which also used
the former. The new `magit-untracked-files' is essentially the same
as that short-lived function, but preserves its own function signature.
|
|
Never limit the list of files to those in `default-directory' and
always return paths relative to the top-level. This affects other
`magit-*-files' functions and their callers.
Some callers of these functions explicitly used `magit-with-toplevel'
and we can stop doing that now. Other callers did not use that macro
but should have done so. Among those, many were always called from the
top-level, so this bug was theoretical in those cases. Others are more
likely to be called from a subdirectory. There are no callers that
actually need just the files from a subdirectory.
|
|
That is cheaper than `magit-with-toplevel'.
|
|
Two definitions have to be moved.
|
|
|
|
|
|
Predicates are evaluate with the minibuffer as the current buffer.
Unlike for other completion frameworks, Helm does not ensure that
the value of `default-directory' in that buffer is the same as in
the buffer from which completion was invoked, making it necessary
to explicitly reinforce the expected value.
Closes #5546.
|
|
|
|
In [1: 7fe84a4cd0] we started using the new `magit--early-process-lines'
but that did not take into account that `string-match-p' may end up with
nil as STRING, which is a type error.
Closes #5548.
|
|
This is a potential replacement for `magit-untracked-files', but
actually replacing that requires more work.
|
|
I.e., support visiting a blob via its blob oid without
knowing a commit and tree path in which it can be found.
|
|
|
|
|
|
|
|
Closes #5544.
|
|
|
|
|
|
We enable `magit-git-debug' in hairy cases, in which case it helps
to avoid any possible confusion, such about whether a given message
is coming from here or elsewhere.
|
|
Returning the Git error message causes many caller to signal a Lisp
error, which isn't what we want when we enable `magit-git-debug'.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Closes #5538.
|
|
|
|
magit-find-file-noselect inserts blob contents via
magit--refresh-blob-buffer. As of f55bfaf79 (Set new magit-blob-oid
in blob buffers and only refresh if necessary, 2026-02-03),
magit--refresh-blob-buffer inserts the blob contents only if the value
returned by magit-blob-oid is different from what's stored in
magit-buffer-blob-oid (unless optional FORCE argument is non-nil).
Over TRAMP, magit-blob-oid returns nil because the file name with a
remote identifier is passed to ls-tree and ls-files. This nil value
is the same as the initial magit-buffer-blob-oid value, leading to
commands like magit-ediff-stage and magit-diff-visit-file generating
empty buffers for blobs.
Update magit-blob-oid and magit--file-index-stages to call
magit-convert-filename-for-git so that the local file name is passed
to ls-tree/ls-files.
Fixes #5529.
|
|
Closes #5523.
|
|
Not only did my handcrafted url-shortener break, the actual
page at the target always read just "Under construction". ;P
|
|
|
|
|
|
|
|
Also ignore stderr when determining the first line of output to be
returned. (When `magit-git-debug' is non-nil, it is still inserted
into the process buffer.)
The new implementation is similar to the experimental
`magit-git-string-p', except that that did not ignore stderr, which
I consider a bug. Define `magit-git-string-p' as an obsolete alias
of `magit-git-debug', despite this change in behavior; doing so is
more likely to fix latent bugs than to be a breaking change.
|
|
In the only two cases where we used this function instead of
`magit-git-string', that did not make a difference.
Also see next commit, which changes `magit-git-string' to take some
inspiration from this function, but without being exactly the same.
|
|
We stopped doing that in [1: 5c2ca6e2b2] for the benefit of its
only caller, which doesn't need that anymore since the previous
commit.
1: 2015-07-07 5c2ca6e2b2af877d715869f3fd265f706ab35b45
magit-rev-head-p: deal with invalid input
|
|
|
|
|
|
Replace `magit-rev-hash' and some uses of `magit-commit-p',
preparing for `magit-commit-p' to return t instead of the oid.
|
|
|
|
|
|
|
|
Continue to return the resolved but abbreviated refname, or nil
if the remote tracking branch does not exist. However, no longer
assume that the full ref begins with "refs/remotes/".
|
|
|
|
|
|
Emacs 31.1 adds variable `lisp-indent-local-overrides'.
|
|
|
|
|
|
|
