diff options
| author | Jonas Bernoulli <jonas@bernoul.li> | 2025-02-11 11:33:00 +0100 |
|---|---|---|
| committer | Jonas Bernoulli <jonas@bernoul.li> | 2025-02-11 11:33:00 +0100 |
| commit | 9a5228e2a952cd95c3585070865d1af158fc57ad (patch) | |
| tree | 07b7309db83f7d0950736311ff167c7fd666017b /lisp/magit-bisect.el | |
| parent | 7116d0572765ab4ca79084e16536fa54f5cffdfd (diff) | |
Call magit-insert-heading less often without arguments
Only call `magit-insert-heading' without any arguments while washing the
output of `git-diff' or `git-log' in place, to *mark* the border between
the heading and body and change the appearance of the heading.
In all other cases, when explicitly inserting the text to be used as the
heading, use `magit-insert-heading' itself to do it, instead of `insert'
followed by `magit-insert-heading' without arguments. We already did
this in most cases, now we consistently do it in all cases.
In the future we might instead want to use two distinct functions.
Diffstat (limited to 'lisp/magit-bisect.el')
| -rw-r--r-- | lisp/magit-bisect.el | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lisp/magit-bisect.el b/lisp/magit-bisect.el index 5f07764..3d64daa 100644 --- a/lisp/magit-bisect.el +++ b/lisp/magit-bisect.el @@ -299,9 +299,9 @@ bisect run'." (narrow-to-region beg (point)) (goto-char (point-min)) (magit-insert-section (bisect-item heading t) - (insert (propertize heading 'font-lock-face - 'magit-section-secondary-heading)) - (magit-insert-heading) + (magit-insert-heading + (propertize heading 'font-lock-face + 'magit-section-secondary-heading)) (magit-wash-sequence (apply-partially #'magit-log-wash-rev 'bisect-log (magit-abbrev-length))) |