aboutsummaryrefslogtreecommitdiff
path: root/lisp/git-commit.el
diff options
context:
space:
mode:
authorJonas Bernoulli <jonas@bernoul.li>2015-08-08 19:54:42 +0200
committerJonas Bernoulli <jonas@bernoul.li>2015-08-08 19:54:42 +0200
commit42e4632ed4925fc65f95ff03e55e80d04e62ffb2 (patch)
tree4ea54b4d2aff424001993d69d5e6c2a147b79036 /lisp/git-commit.el
parent43aa38b93d00161bd5f94ee792543611830aa3f7 (diff)
use async-bytecomp to guarantee untainted builds
When `package.el' is used to update a package whose libraries have already been loaded in the current session, then parts of the loaded version can leak into the new version during byte-compilation. This can be avoided by compiling the libraries in a separate Emacs instance. The library `async-bytecomp', which is part of the package `async', does just that by advising the function `package--compile'. So add `async' as an Elpa dependency, soft-require `async-bytecomp', and if that succeeds, then turn on `async-bytecomp-package-mode' to activate the advice. Because it is undefined which package is updated first, and which library is loaded first, we have to this in both possible candidates `with-editor' and `magit-popup'. Users may update `magit' without updating the dependencies, so we have to further force the updates of all the Elpa packages that are build from the Melpa repository. To do so we depend on "20150808" snapshot versions instead of "2.2.0". When installing Magit manually, then `async-bytecomp' is not required, because Magit is then compiled using the Makefile which already uses a separate, untainted Emacs instance.
Diffstat (limited to 'lisp/git-commit.el')
-rw-r--r--lisp/git-commit.el2
1 files changed, 1 insertions, 1 deletions
diff --git a/lisp/git-commit.el b/lisp/git-commit.el
index 8af116d..c5a7910 100644
--- a/lisp/git-commit.el
+++ b/lisp/git-commit.el
@@ -11,7 +11,7 @@
;; Marius Vollmer <marius.vollmer@gmail.com>
;; Maintainer: Jonas Bernoulli <jonas@bernoul.li>
-;; Package-Requires: ((emacs "24.4") (dash "2.10.0") (with-editor "2.1.0"))
+;; Package-Requires: ((emacs "24.4") (dash "2.11.0") (with-editor "20150808"))
;; Keywords: git tools vc
;; Homepage: https://github.com/magit/magit