aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonas Bernoulli <jonas@bernoul.li>2025-10-04 19:20:30 +0200
committerJonas Bernoulli <jonas@bernoul.li>2025-10-04 19:20:30 +0200
commitb5066e5fa4000df474e5fb35b417b76d32e8131f (patch)
tree88bfcb63eef4f3fd1ba0fefe341206ccee8b24ed
parent3537c811fcd5220cdf7039a4ac3c76c9236f1e1b (diff)
magit-completing-read-multiple: Restore meaning of t as REQUIRE-MATCH
As for `completing-read-multiple', if REQUIRE-MATCH is t, then all inputs must appear in the collection, but it is again possible to select nothing. Forge's uses of this function need this behavior. In [1: 4e2dd7ba6f] I should only have added the new `any' value, instead of also changing the meaning of t. Closes magit/forge#814. 1: 2025-08-16 4e2dd7ba6f54b2251a702b4c0416467d7315407a magit-completing-read-multiple: Support requiring non-empty input
-rw-r--r--lisp/magit-base.el3
1 files changed, 2 insertions, 1 deletions
diff --git a/lisp/magit-base.el b/lisp/magit-base.el
index 77e818a..99566a8 100644
--- a/lisp/magit-base.el
+++ b/lisp/magit-base.el
@@ -715,7 +715,8 @@ third-party completion frameworks."
table predicate
(if (eq require-match 'any) nil require-match)
initial-input hist def inherit-input-method)))
- (when (and require-match (not values))
+ (when (and (eq require-match 'any)
+ (not values))
(user-error "Nothing selected"))
(if no-split input values)))