aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonas Bernoulli <jonas@bernoul.li>2025-07-29 20:55:13 +0200
committerJonas Bernoulli <jonas@bernoul.li>2025-07-29 20:55:13 +0200
commita6b9d5597730d4e99f1f4eec04d7cef1bcda3424 (patch)
tree33e59e095d3a6a49a47b1f0c8ad41039a492bae0
parent406a3094a883ecf45df277fa920e7ec547b5552a (diff)
Add to eieio--known-slot-names at run-time too
The libraries that make these additions are not the only ones that use them before the respective classes are defined. When compiling those other libraries we also don't want these warnings.
-rw-r--r--lisp/magit-diff.el7
-rw-r--r--lisp/magit-git.el5
-rw-r--r--lisp/magit-sequence.el9
3 files changed, 9 insertions, 12 deletions
diff --git a/lisp/magit-diff.el b/lisp/magit-diff.el
index 5032177..f5bf512 100644
--- a/lisp/magit-diff.el
+++ b/lisp/magit-diff.el
@@ -87,10 +87,9 @@
(declare-function magit-smerge-keep-base "magit-apply" ())
(declare-function magit-smerge-keep-lower "magit-apply" ())
-(eval-when-compile
- (cl-pushnew 'orig-rev eieio--known-slot-names)
- (cl-pushnew 'action-type eieio--known-slot-names)
- (cl-pushnew 'target eieio--known-slot-names))
+(cl-pushnew 'orig-rev eieio--known-slot-names)
+(cl-pushnew 'action-type eieio--known-slot-names)
+(cl-pushnew 'target eieio--known-slot-names)
(define-obsolete-variable-alias 'magit-diff-section-base-map
'magit-diff-section-map "Magit 4.0.0")
diff --git a/lisp/magit-git.el b/lisp/magit-git.el
index b7a6422..93c0309 100644
--- a/lisp/magit-git.el
+++ b/lisp/magit-git.el
@@ -66,9 +66,8 @@
;; From `magit-status'.
(defvar magit-status-show-untracked-files)
-(eval-when-compile
- (cl-pushnew 'orig-rev eieio--known-slot-names)
- (cl-pushnew 'number eieio--known-slot-names))
+(cl-pushnew 'orig-rev eieio--known-slot-names)
+(cl-pushnew 'number eieio--known-slot-names)
;;; Options
diff --git a/lisp/magit-sequence.el b/lisp/magit-sequence.el
index 3680229..d0f1659 100644
--- a/lisp/magit-sequence.el
+++ b/lisp/magit-sequence.el
@@ -32,11 +32,10 @@
;; For `magit-rebase--todo'.
(declare-function git-rebase-current-line "git-rebase" (&optional batch))
-(eval-when-compile
- (cl-pushnew 'action-type eieio--known-slot-names)
- (cl-pushnew 'action eieio--known-slot-names)
- (cl-pushnew 'action-options eieio--known-slot-names)
- (cl-pushnew 'target eieio--known-slot-names))
+(cl-pushnew 'action-type eieio--known-slot-names)
+(cl-pushnew 'action eieio--known-slot-names)
+(cl-pushnew 'action-options eieio--known-slot-names)
+(cl-pushnew 'target eieio--known-slot-names)
;;; Options
;;;; Faces