diff options
| author | York Zhao <gtdplatform@gmail.com> | 2014-03-23 14:19:52 -0400 |
|---|---|---|
| committer | York Zhao <gtdplatform@gmail.com> | 2014-03-23 14:19:52 -0400 |
| commit | e3cdfa91079906df0d012a737512d9c478ed735c (patch) | |
| tree | d452c3554d23a73f29cbde5c9569307e901cc0da /evil-integration.el | |
| parent | 43d541e308945eac5587968222e54c2556531dcb (diff) | |
Do not copy original keymap when making overriding map
When calling `evil-make-overriding-map', do not specify 'copy because doing so
would cause KEYMAP been "frozen" in whatever state it is, i.e., any binding on
the original map after this point will not take effect. For example, if user
(or some other package) binds some key in `dired-mode-map' after Evil has been
loaded by using `(define-key dired-mode-map "SOME-KEY" 'SOME-COMMAND)' that
binding will never take effect because it is the copy of `dired-mode-map' rather
than the original map that is in use.
Diffstat (limited to 'evil-integration.el')
| -rw-r--r-- | evil-integration.el | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/evil-integration.el b/evil-integration.el index 3ca2d62..a1f3888 100644 --- a/evil-integration.el +++ b/evil-integration.el @@ -111,7 +111,7 @@ '(progn ;; use the standard Dired bindings as a base (defvar dired-mode-map) - (evil-make-overriding-map dired-mode-map 'normal t) + (evil-make-overriding-map dired-mode-map 'normal) (evil-add-hjkl-bindings dired-mode-map 'normal "J" 'dired-goto-file ; "j" "K" 'dired-do-kill-lines ; "k" @@ -200,7 +200,7 @@ (eval-after-load 'ibuffer '(progn (defvar ibuffer-mode-map) - (evil-make-overriding-map ibuffer-mode-map 'normal t) + (evil-make-overriding-map ibuffer-mode-map 'normal) (evil-define-key 'normal ibuffer-mode-map "j" 'evil-next-line "k" 'evil-previous-line |