From 90bd7ce81435c456326f416b323c970a6a897905 Mon Sep 17 00:00:00 2001 From: Jan-Hendrik Willms Date: Fri, 25 Aug 2023 15:31:47 +0200 Subject: fail proof extractCallback() and don't let dialogs break on error, fixes #3098 --- resources/assets/javascripts/lib/dialog.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/resources/assets/javascripts/lib/dialog.js b/resources/assets/javascripts/lib/dialog.js index 8f6e50a..da2a8f2 100644 --- a/resources/assets/javascripts/lib/dialog.js +++ b/resources/assets/javascripts/lib/dialog.js @@ -291,7 +291,11 @@ Dialog.fromURL = function(url, options) { var value = xhr.getResponseHeader(header), result = true; if (value !== null) { - result = handler(value, options, xhr); + try { + result = handler(value, options, xhr); + } catch (e) { + console.error(e); + } } advance = advance && result !== false; return result; -- cgit v1.0