From f26acf3c8be2b8e4f9a6dcc3089c16273d416bff Mon Sep 17 00:00:00 2001 From: Jan-Hendrik Willms Date: Fri, 11 Jul 2025 08:54:12 +0200 Subject: prevent php8 warnings, fixes #5711 Closes #5711 Merge request studip/studip!4341 --- lib/modules/IliasInterfaceModule.php | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/modules/IliasInterfaceModule.php b/lib/modules/IliasInterfaceModule.php index 97a3286..fdda3e3 100644 --- a/lib/modules/IliasInterfaceModule.php +++ b/lib/modules/IliasInterfaceModule.php @@ -131,22 +131,28 @@ class IliasInterfaceModule extends CorePlugin implements StudipModule, SystemPlu } $moduletitle = Config::get()->ILIAS_INTERFACE_MODULETITLE; - if ($ilias_interface_config['edit_moduletitle']) { + if (!empty($ilias_interface_config['edit_moduletitle'])) { $moduletitle = CourseConfig::get($course_id)->ILIAS_INTERFACE_MODULETITLE; } $navigation = new Navigation($moduletitle); $navigation->setImage(Icon::create('learnmodule', Icon::ROLE_INFO_ALT)); $navigation->setActiveImage(Icon::create('learnmodule', Icon::ROLE_INFO)); - if ($GLOBALS['perm']->have_studip_perm('tutor', $course_id) || ($GLOBALS['perm']->have_studip_perm('autor', $course_id) && IliasObjectConnections::isCourseConnected($course_id))) { + if ( + $GLOBALS['perm']->have_studip_perm('tutor', $course_id) + || ( + $GLOBALS['perm']->have_studip_perm('autor', $course_id) + && IliasObjectConnections::isCourseConnected($course_id) + ) + ) { if (get_object_type($course_id, ['inst'])) { - if ($ilias_interface_config['create_objects']) { + if (!empty($ilias_interface_config['create_objects'])) { $navigation->addSubNavigation('view', new Navigation(_('Lernobjekte dieser Einrichtung'), 'dispatch.php/course/ilias_interface/index/' . $course_id)); } else { $navigation->addSubNavigation('view', new Navigation(_('ILIAS-Kurs zu dieser Einrichtung'), 'dispatch.php/course/ilias_interface/index/' . $course_id)); } } else { - if ($ilias_interface_config['create_objects']) { + if (!empty($ilias_interface_config['create_objects'])) { $navigation->addSubNavigation('view', new Navigation(_('Lernobjekte dieser Veranstaltung'), 'dispatch.php/course/ilias_interface/index/' . $course_id)); } else { $navigation->addSubNavigation('view', new Navigation(_('ILIAS-Kurs zu dieser Veranstaltung'), 'dispatch.php/course/ilias_interface/index/' . $course_id)); -- cgit v1.0