From 874bd358f5ecc2e148a6ad36bcf155fe738c107a Mon Sep 17 00:00:00 2001 From: Ron Lucke Date: Wed, 10 Jan 2024 14:04:02 +0000 Subject: TIC #3260 Merge request studip/studip!2378 --- app/controllers/courseware_controller.php | 1 - resources/vue/components/courseware/IndexApp.vue | 5 -- .../blocks/CoursewareBeforeAfterBlock.vue | 8 +-- .../courseware/blocks/CoursewareDefaultBlock.vue | 2 +- .../containers/CoursewareAccordionContainer.vue | 7 +-- .../containers/CoursewareDefaultContainer.vue | 4 +- .../containers/CoursewareListContainer.vue | 7 +-- .../containers/CoursewareTabsContainer.vue | 7 +-- .../CoursewareEmptyElementBox.vue | 33 +++------- .../structural-element/CoursewareRibbonToolbar.vue | 8 --- .../CoursewareStructuralElement.vue | 16 +++-- .../structural-element/CoursewareTree.vue | 7 +-- .../structural-element/CoursewareTreeItem.vue | 22 +++---- .../structural-element/CoursewareWelcomeScreen.vue | 3 - .../courseware/toolbar/CoursewareToolbar.vue | 25 ++++---- .../courseware/widgets/CoursewareViewWidget.vue | 71 ---------------------- .../vue/store/courseware/courseware.module.js | 15 ++++- 17 files changed, 62 insertions(+), 179 deletions(-) delete mode 100644 resources/vue/components/courseware/widgets/CoursewareViewWidget.vue diff --git a/app/controllers/courseware_controller.php b/app/controllers/courseware_controller.php index eaec609..faf7393 100644 --- a/app/controllers/courseware_controller.php +++ b/app/controllers/courseware_controller.php @@ -81,6 +81,5 @@ abstract class CoursewareController extends AuthenticatedController $sidebar->addWidget(new VueWidget('courseware-action-widget')); SkipLinks::addIndex(_('Aktionen'), 'courseware-action-widget', 21); $sidebar->addWidget(new VueWidget('courseware-search-widget')); - $sidebar->addWidget(new VueWidget('courseware-view-widget')); } } diff --git a/resources/vue/components/courseware/IndexApp.vue b/resources/vue/components/courseware/IndexApp.vue index 2ac86c2..53238b4 100644 --- a/resources/vue/components/courseware/IndexApp.vue +++ b/resources/vue/components/courseware/IndexApp.vue @@ -15,9 +15,6 @@ - - - @@ -69,7 +69,7 @@ import BlockComponents from './block-components.js'; import blockMixin from '@/vue/mixins/courseware/block.js'; import TwentyTwenty from 'vue-twentytwenty'; import 'vue-twentytwenty/dist/vue-twentytwenty.css'; -import { mapActions, mapGetters } from 'vuex'; +import { mapActions } from 'vuex'; export default { name: 'courseware-before-after-block', @@ -99,7 +99,6 @@ export default { computed: { ...mapGetters({ fileRefById: 'file-refs/byId', - viewMode: 'viewMode', }), beforeSource() { return this.block?.attributes?.payload?.before_source; @@ -140,9 +139,6 @@ export default { isEmpty() { return this.currentBeforeUrl === '' || this.currentAfterUrl === ''; }, - editMode() { - return this.viewMode === 'edit'; - }, }, mounted() { if (this.block.id) { diff --git a/resources/vue/components/courseware/blocks/CoursewareDefaultBlock.vue b/resources/vue/components/courseware/blocks/CoursewareDefaultBlock.vue index 2fabdda..6bac6ff 100644 --- a/resources/vue/components/courseware/blocks/CoursewareDefaultBlock.vue +++ b/resources/vue/components/courseware/blocks/CoursewareDefaultBlock.vue @@ -155,7 +155,7 @@ export default { currentElementisLink: 'currentElementisLink', }), showEditMode() { - let show = (this.viewMode === 'edit' || this.blockedByThisUser) && !this.currentElementisLink; + let show = this.canEdit && !this.currentElementisLink; if (!show) { this.displayFeature(false); } diff --git a/resources/vue/components/courseware/containers/CoursewareAccordionContainer.vue b/resources/vue/components/courseware/containers/CoursewareAccordionContainer.vue index c45f03a..75db30c 100644 --- a/resources/vue/components/courseware/containers/CoursewareAccordionContainer.vue +++ b/resources/vue/components/courseware/containers/CoursewareAccordionContainer.vue @@ -10,7 +10,7 @@ @closeEdit="initCurrentData" >