From 956bc89af815fe31b0ef68721f051eb80c24786d Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+github@gmail.com>
Date: Thu, 3 Feb 2022 14:00:22 +0100
Subject: transfer changeset 59448 from svn

---
 app/controllers/my_courses.php                     | 14 +++----
 app/controllers/my_institutes.php                  |  8 +---
 app/controllers/search/courses.php                 |  5 +--
 app/controllers/search/globalsearch.php            |  4 +-
 app/controllers/studip_controller.php              |  6 +--
 app/views/messages/overview.php                    |  6 +--
 app/views/search/globalsearch/index.php            |  2 +-
 lib/classes/Assets.class.php                       |  5 +--
 lib/classes/MyRealmModel.php                       | 10 ++---
 lib/classes/QuickSearch.class.php                  | 18 ++++-----
 lib/classes/Request.class.php                      |  2 +-
 lib/classes/SemBrowse.class.php                    | 44 ++++++++++++----------
 lib/classes/SemClass.class.php                     | 10 +++--
 lib/classes/Seminar.class.php                      |  6 ++-
 lib/classes/SeminarCategories.class.php            | 10 +++--
 lib/classes/Smiley.php                             |  2 +-
 lib/classes/StudipSemSearch.class.php              |  1 +
 lib/classes/StudipSemTree.class.php                |  2 +-
 lib/classes/StudipSemTreeViewSimple.class.php      |  5 ++-
 lib/classes/TreeAbstract.class.php                 | 14 +++++--
 lib/classes/helpbar/Helpbar.php                    |  4 +-
 lib/classes/searchtypes/SearchType.class.php       |  1 +
 lib/classes/sidebar/SelectWidget.php               |  2 +
 lib/functions.php                                  |  4 +-
 lib/models/Semester.class.php                      |  6 ++-
 lib/models/SimpleORMap.class.php                   | 16 ++++----
 lib/navigation/BrowseNavigation.php                |  2 +-
 lib/plugins/engine/PluginManager.class.php         |  3 +-
 .../core/Forum/models/ForumVisit.php               |  4 +-
 templates/quicksearch/inputfield.php               |  2 +-
 templates/sidebar/list-widget.php                  |  4 +-
 templates/sidebar/search-widget.php                |  2 +-
 32 files changed, 121 insertions(+), 103 deletions(-)

diff --git a/app/controllers/my_courses.php b/app/controllers/my_courses.php
index 395bef9..fa6699c 100644
--- a/app/controllers/my_courses.php
+++ b/app/controllers/my_courses.php
@@ -723,14 +723,14 @@ class MyCoursesController extends AuthenticatedController
     public function check_course($seminar_content)
     {
 
-        if ($seminar_content['visitdate'] <= $seminar_content['chdate'] || $seminar_content['last_modified'] > 0) {
-            $last_modified = $seminar_content['visitdate'] <= $seminar_content['chdate']
-            && $seminar_content['chdate'] > $seminar_content['last_modified']
-                ? $seminar_content['chdate']
-                : $seminar_content['last_modified'];
-            if ($last_modified) {
+        if ($seminar_content['visitdate'] <= $seminar_content['chdate']) {
                 return true;
-            }
+            // $last_modified = $seminar_content['visitdate'] <= $seminar_content['chdate']
+            //                ? $seminar_content['chdate']
+            //                : $seminar_content['last_modified'];
+            // if ($last_modified) {
+            //     return true;
+            // }
         }
 
         $plugins_navigation = $seminar_content['navigation'];
diff --git a/app/controllers/my_institutes.php b/app/controllers/my_institutes.php
index 0bdff85..c3d5c2f 100644
--- a/app/controllers/my_institutes.php
+++ b/app/controllers/my_institutes.php
@@ -83,14 +83,8 @@ class MyInstitutesController extends AuthenticatedController
 
     protected function check_institute($institute): bool
     {
-        if ($institute['visitdate'] || $institute['last_modified']) {
-            if ($institute['visitdate'] <= $institute["chdate"] || $institute['last_modified'] > 0) {
-                $last_modified = ($institute['visitdate'] <= $institute["chdate"]
-                && $institute["chdate"] > $institute['last_modified'] ? $institute["chdate"] : $institute['last_modified']);
-                if ($last_modified) {
+        if ($institute['visitdate'] && $institute['visitdate'] <= $institute["chdate"]) {
                     return true;
-                }
-            }
         }
 
         $plugins = $institute['navigation'];
diff --git a/app/controllers/search/courses.php b/app/controllers/search/courses.php
index 9a3294c..cd38f94 100644
--- a/app/controllers/search/courses.php
+++ b/app/controllers/search/courses.php
@@ -30,8 +30,7 @@ class Search_CoursesController extends AuthenticatedController
         // activate navigation item
         $nav_options = Config::get()->COURSE_SEARCH_NAVIGATION_OPTIONS;
         URLHelper::bindLinkParam('option', $this->nav_option);
-        if ($nav_options[$this->nav_option]
-                && Navigation::hasItem('/search/courses/' . $this->nav_option)) {
+        if (!empty($nav_options[$this->nav_option]) && Navigation::hasItem('/search/courses/' . $this->nav_option)) {
             Navigation::activateItem('/search/courses/' . $this->nav_option);
         } else {
             URLHelper::removeLinkParam('option');
@@ -114,7 +113,7 @@ class Search_CoursesController extends AuthenticatedController
         }
 
         // show information about course class if class was changed
-        $class = $GLOBALS['SEM_CLASS'][$_SESSION['sem_browse_data']['show_class']];
+        $class = $GLOBALS['SEM_CLASS'][$_SESSION['sem_browse_data']['show_class']] ?? null;
         if (is_object($class) && $class->countSeminars() > 0) {
             if (trim($GLOBALS['SEM_CLASS'][$_SESSION['sem_browse_data']['show_class']]['description'])) {
                 PageLayout::postInfo(sprintf(_('Gewählte Veranstaltungsklasse <i>%1s</i>: %2s'),
diff --git a/app/controllers/search/globalsearch.php b/app/controllers/search/globalsearch.php
index 49c2861..9c41112 100644
--- a/app/controllers/search/globalsearch.php
+++ b/app/controllers/search/globalsearch.php
@@ -90,7 +90,7 @@ class Search_GlobalsearchController extends AuthenticatedController
             null,
             'seminar_type',
             $this->getSemClasses(),
-            $_SESSION['global_search']['selects']['seminar_type'],
+            $_SESSION['global_search']['selects']['seminar_type'] ?? null,
             ['id' => 'seminar_type_select']
         );
 
@@ -101,7 +101,7 @@ class Search_GlobalsearchController extends AuthenticatedController
             null,
             'institute',
             $this->getInstitutes(),
-            $_SESSION['global_search']['selects']['institute'],
+            $_SESSION['global_search']['selects']['institute'] ?? null,
             ['id' => 'institute_select']
         );
     }
diff --git a/app/controllers/studip_controller.php b/app/controllers/studip_controller.php
index 357ded7..a299915 100644
--- a/app/controllers/studip_controller.php
+++ b/app/controllers/studip_controller.php
@@ -163,11 +163,11 @@ abstract class StudipController extends Trails_Controller
             $reflection = new ReflectionMethod($this, $this->current_action . '_action');
             $parameters = $reflection->getParameters();
             foreach ($parameters as $i => $parameter) {
-                $class_type = $parameter->getClass();
+                $class_type = $parameter->getType();
 
                 if (!$class_type
-                    || !class_exists($class_type->name)
-                    || !is_a($class_type->name, SimpleORMap::class, true))
+                    || !class_exists($class_type->getName())
+                    || !is_a($class_type->getName(), SimpleORMap::class, true))
                 {
                     continue;
                 }
diff --git a/app/views/messages/overview.php b/app/views/messages/overview.php
index 1a1decb..c30ac6b 100644
--- a/app/views/messages/overview.php
+++ b/app/views/messages/overview.php
@@ -40,7 +40,7 @@
 
         <tbody aria-relevant="additions" aria-live="polite" data-shiftcheck>
             <? if (count($messages) > 0) : ?>
-                <? if ($more || (Request::int("offset") > 0)) : ?>
+                <? if (($more ?? false) || (Request::int("offset") > 0)) : ?>
                 <noscript>
                 <tr>
                     <td colspan="8">
@@ -57,9 +57,9 @@
                 </noscript>
                 <? endif ?>
                 <? foreach ($messages as $message) : ?>
-                <?= $this->render_partial("messages/_message_row.php", compact("message", "received". "settings")) ?>
+                <?= $this->render_partial("messages/_message_row.php", compact("message", "received", "settings")) ?>
                 <? endforeach ?>
-                <? if ($more || (Request::int("offset") > 0)) : ?>
+                <? if (($more ?? false) || (Request::int("offset") > 0)) : ?>
                 <noscript>
                 <tr>
                     <td colspan="7">
diff --git a/app/views/search/globalsearch/index.php b/app/views/search/globalsearch/index.php
index e85aa8f..637873e 100644
--- a/app/views/search/globalsearch/index.php
+++ b/app/views/search/globalsearch/index.php
@@ -1,7 +1,7 @@
 <form class="default" onsubmit="return false;" autocomplete="off">
     <div id="div-search-input" class="input-group files-search">
         <input type="text" autofocus name="searchtext" id="search-input"
-            value="<?= htmlReady($_SESSION['search_text']) ?>"
+            value="<?= htmlReady($_SESSION['search_text'] ?? '') ?>"
             placeholder="<?= _('Was suchen Sie?') ?>">
 
         <span class="input-group-append">
diff --git a/lib/classes/Assets.class.php b/lib/classes/Assets.class.php
index 1d9c23f..453d67c 100644
--- a/lib/classes/Assets.class.php
+++ b/lib/classes/Assets.class.php
@@ -145,7 +145,7 @@ class Assets
 
         $parts = explode('/', $source);
 
-        $size = $opt['size'];
+        $size = $opt['size'] ?? null;
 
         $opt = Assets::parse_attributes($opt);
 
@@ -156,7 +156,7 @@ class Assets
         }
 
         if (isset($size) && !isset($opt['width'])) {
-            list($opt['width'], $opt['height']) = explode('@', $size, 2);
+            @list($opt['width'], $opt['height']) = explode('@', $size, 2);
             unset($opt['size']);
         }
 
@@ -413,4 +413,3 @@ class Assets
         return $attributes;
     }
 }
-
diff --git a/lib/classes/MyRealmModel.php b/lib/classes/MyRealmModel.php
index a68a0c1..bdd5646 100644
--- a/lib/classes/MyRealmModel.php
+++ b/lib/classes/MyRealmModel.php
@@ -308,8 +308,8 @@ class MyRealmModel
         foreach ($courses as $index => $course) {
             // export object to array for simple handling
             $_course = $course->toArray($param_array);
-            $_course['start_semester'] = $course->start_semester->name;
-            $_course['end_semester']   = $course->end_semester->name;
+            $_course['start_semester'] = $course->start_semester ? $course->start_semester->name : null;
+            $_course['end_semester']   = $course->end_semester ? $course->end_semester->name : null;
             $_course['sem_class']      = $course->getSemClass();
             $_course['obj_type']       = 'sem';
 
@@ -341,7 +341,7 @@ class MyRealmModel
             $_course['user_status']    = $user_status;
             $_course['gruppe']         = !$is_deputy ? @$member_ships[$course->id]['gruppe'] : $deputy->gruppe;
             $_course['sem_number_end'] = $course->isOpenEnded() ? $max_sem_key : Semester::getIndexById($course->end_semester->id);
-            $_course['sem_number']     = Semester::getIndexById($course->start_semester->id);
+            $_course['sem_number']     = $course->start_semester ? Semester::getIndexById($course->start_semester->id) : null;
             $_course['tools']        = $course->tools;
             $_course['name']           = $course->name;
             $_course['temp_name']      = $course->name;
@@ -364,7 +364,7 @@ class MyRealmModel
 
             // add the the course to the correct semester
 
-            if (!$_course['parent_course']) {
+            if (empty($_course['parent_course'])) {
                 if ($course->isOpenEnded()) {
                     if ($current_semester_nr >= $min_sem_key && $current_semester_nr <= $max_sem_key) {
                         $sem_courses[$current_semester_nr][$course->id] = $_course;
@@ -395,7 +395,7 @@ class MyRealmModel
             return null;
         }
 
-        if ($params['main_navigation']) {
+        if (isset($params['main_navigation'])) {
             return $sem_courses;
         }
 
diff --git a/lib/classes/QuickSearch.class.php b/lib/classes/QuickSearch.class.php
index 56bcc77..adcf0aa 100644
--- a/lib/classes/QuickSearch.class.php
+++ b/lib/classes/QuickSearch.class.php
@@ -197,9 +197,9 @@ class QuickSearch
         if (isset($design['width'])) {
             $this->box_width = $design['width'];
         }
-        $this->box_align = $design['align'] ? $design['align'] : "right";
-        $this->search_button_name = $design['search_button_name'];
-        $this->reset_button_name = $design['reset_button_name'];
+        $this->box_align = $design['align'] ?? 'right';
+        $this->search_button_name = $design['search_button_name'] ?? null;
+        $this->reset_button_name = $design['reset_button_name'] ?? null;
         return $this;
     }
 
@@ -354,7 +354,7 @@ class QuickSearch
             $template->set_attribute('withAttributes', $this->withAttributes);
             $template->set_attribute('searchresults', $searchresults);
             $template->set_attribute('name', $this->name);
-            $template->set_attribute('inputClass', $this->inputClass);
+            $template->set_attribute('inputClass', $this->withAttributes['class'] ?? '');
             $template->set_attribute('search_button_name', $this->search_button_name);
             $template->set_attribute('reset_button_name', $this->reset_button_name);
             $template->set_attribute('extendedLayout', $this->hasExtendedLayout());
@@ -363,9 +363,7 @@ class QuickSearch
         } else {
             //Abfrage in der Session speichern:
             $query_id = md5(serialize($this->search));
-            if ($this->specialQuery) {
-                $_SESSION['QuickSearches'][$query_id]['query'] = $this->specialQuery;
-            } elseif ($this->search instanceof SearchType) {
+            if ($this->search instanceof SearchType) {
                 $_SESSION['QuickSearches'][$query_id]['object'] = serialize($this->search);
                 if ($this->search instanceof SearchType) {
                     $_SESSION['QuickSearches'][$query_id]['includePath'] = $this->search->includePath();
@@ -381,13 +379,13 @@ class QuickSearch
             $template->set_attribute('withButton', $this->withButton);
             $template->set_attribute('box_align', $this->box_align);
             $template->set_attribute('box_width', $this->box_width);
-            $template->set_attribute('inputStyle', $this->inputStyle ? $this->inputStyle : "");
+            $template->set_attribute('inputStyle', $this->withAttributes['style'] ?? '');
             $template->set_attribute('beschriftung', $this->beschriftung());
             $template->set_attribute('name', $this->name);
             $template->set_attribute('defaultID', $this->defaultID);
             $template->set_attribute('defaultName', $this->defaultName);
-            $template->set_attribute('inputClass', $this->inputClass);
-            $template->set_attribute('withAttributes', $this->withAttributes ? $this->withAttributes : []);
+            $template->set_attribute('inputClass', $this->withAttributes['class'] ?? '');
+            $template->set_attribute('withAttributes', $this->withAttributes ?: []);
             $template->set_attribute('jsfunction', $this->jsfunction);
             $template->set_attribute('autocomplete_disabled', Config::get()->getValue("AJAX_AUTOCOMPLETE_DISABLED") || $this->autocomplete_disabled);
             $template->set_attribute('count_QS', self::$count_QS);
diff --git a/lib/classes/Request.class.php b/lib/classes/Request.class.php
index 410a74f..e4d5472 100644
--- a/lib/classes/Request.class.php
+++ b/lib/classes/Request.class.php
@@ -632,7 +632,7 @@ class Request implements ArrayAccess, IteratorAggregate
      */
     public static function method()
     {
-        return mb_strtoupper($_SERVER['X_HTTP_METHOD_OVERRIDE'] ?: $_SERVER['REQUEST_METHOD']);
+        return mb_strtoupper($_SERVER['X_HTTP_METHOD_OVERRIDE'] ?? $_SERVER['REQUEST_METHOD']);
     }
 
     /**
diff --git a/lib/classes/SemBrowse.class.php b/lib/classes/SemBrowse.class.php
index af6b2f3..f8a228a 100644
--- a/lib/classes/SemBrowse.class.php
+++ b/lib/classes/SemBrowse.class.php
@@ -105,7 +105,7 @@ class SemBrowse {
             $this->sem_number = false;
         }
 
-        $sem_status = (is_array($this->sem_browse_data['sem_status'])) ? $this->sem_browse_data['sem_status'] : false;
+        $sem_status = $this->sem_browse_data['sem_status'] ?? false;
 
         if ($this->sem_browse_data['level'] == 'vv') {
             if (!$this->sem_browse_data['start_item_id']){
@@ -373,16 +373,16 @@ class SemBrowse {
         ob_start();
 
         echo "\n" . '<table id="sem_search_level" class="course-search" width="100%">' . "\n";
-        if ($this->sem_browse_data['level'] == 'vv') {
+        if ($this->sem_browse_data['level'] === 'vv') {
             echo "\n" . '<caption class="legend">'._('Studienbereiche').'<caption>';
             echo "\n" . '<tr><td align="center">';
-            $this->sem_tree->show_entries = $this->sem_browse_data['show_entries'];
+            $this->sem_tree->show_entries = $this->sem_browse_data['show_entries'] ?? false;
             $this->sem_tree->showSemTree($start_id);
         }
-        if ($this->sem_browse_data['level'] == 'ev') {
+        if ($this->sem_browse_data['level'] === 'ev') {
             echo "\n" . '<caption class="legend">'._('Einrichtungen').'<caption>';
             echo "\n" . '<tr><td align="center">';
-            $this->range_tree->show_entries = $this->sem_browse_data['show_entries'];
+            $this->range_tree->show_entries = $this->sem_browse_data['show_entries'] ?? false;
             $this->range_tree->showSemRangeTree($start_id);
         }
 
@@ -1248,8 +1248,8 @@ class SemBrowse {
                 $_SESSION['sem_browse_data']['qs_choose']);
 
         // simulate button clicked if semester was changed
-        if (Request::option('search_sem_sem', $_SESSION['sem_browse_data']['default_sem'])
-                != $_SESSION['sem_browse_data']['default_sem']) {
+        if (Request::option('search_sem_sem', $_SESSION['sem_browse_data']['default_sem'] ?? null)
+                != ($_SESSION['sem_browse_data']['default_sem'] ?? null)) {
             $_SESSION['sem_browse_data']['default_sem'] = Request::option('search_sem_sem');
             if ($_SESSION['sem_browse_data']['sset']) {
                 Request::set('search_sem_quick_search_parameter', $_SESSION['sem_browse_data']['sset']);
@@ -1293,15 +1293,15 @@ class SemBrowse {
         }
 
         // set default values
-        if (!$_SESSION['sem_browse_data']['default_sem']) {
-            $_SESSION['sem_browse_data']['default_sem'] =
-                    Semester::getIndexById(self::getDefaultSemester(), false, true)
-                        ?: 'all';
+        if (!isset($_SESSION['sem_browse_data']['default_sem'])) {
+            $_SESSION['sem_browse_data']['default_sem'] = Semester::getIndexById(
+                self::getDefaultSemester(),
+                false,
+                true
+            ) ?: 'all';
         }
-        $_SESSION['sem_browse_data']['show_class'] =
-                $_SESSION['sem_browse_data']['show_class'] ?: 'all';
-        $_SESSION['sem_browse_data']['group_by'] =
-                $_SESSION['sem_browse_data']['group_by'] ?: '0';
+        $_SESSION['sem_browse_data']['show_class'] = $_SESSION['sem_browse_data']['show_class'] ?? 'all';
+        $_SESSION['sem_browse_data']['group_by'] = $_SESSION['sem_browse_data']['group_by'] ?? '0';
     }
 
     /**
@@ -1354,14 +1354,18 @@ class SemBrowse {
         $sidebar = Sidebar::Get();
         $list = new SelectWidget(_('Semester'),
                 $submit_url, 'search_sem_sem');
-        $list->addElement(new SelectElement('all', _('Alle'),
-                ($_SESSION['sem_browse_data']['default_sem']) === 'all'));
+        $list->addElement(new SelectElement(
+            'all',
+            _('Alle'),
+            isset($_SESSION['sem_browse_data']['default_sem']) && $_SESSION['sem_browse_data']['default_sem'] === 'all'
+        ));
         foreach(array_reverse($semesters, true) as $i => $semester_data) {
             $list->addElement(new SelectElement(
                 $i,
                 $semester_data['name'],
-                ($_SESSION['sem_browse_data']['default_sem'] !== 'all'
-                    && intval($_SESSION['sem_browse_data']['default_sem']) === $i)
+                isset($_SESSION['sem_browse_data']['default_sem'])
+                    && $_SESSION['sem_browse_data']['default_sem'] !== 'all'
+                    && intval($_SESSION['sem_browse_data']['default_sem']) === $i
             ));
         }
         $sidebar->addWidget($list, 'filter_semester');
@@ -1435,7 +1439,7 @@ class SemBrowse {
             $search_form_content .= $this->search_obj->getHiddenField('range_choose', $this->range_tree->start_item_id);
 
         $search_form_content .= $this->search_obj->getHiddenField('level', $this->sem_browse_data['level']);
-        $search_form_content .= $this->search_obj->getHiddenField('sem', htmlReady($_SESSION['sem_browse_data']['default_sem']));
+        $search_form_content .= $this->search_obj->getHiddenField('sem', htmlReady($_SESSION['sem_browse_data']['default_sem'] ?? ''));
 
         $search_form_content .= $this->search_obj->getFormEnd();
         return $search_form_content;
diff --git a/lib/classes/SemClass.class.php b/lib/classes/SemClass.class.php
index 8f122a3..6b885f1 100644
--- a/lib/classes/SemClass.class.php
+++ b/lib/classes/SemClass.class.php
@@ -93,7 +93,10 @@ class SemClass implements ArrayAccess
 
         foreach ($slots as $slot => $module) {
             $data[$slot] = $module;
-            $modules[$module] = ['activated' => (int) $INST_MODULES[$type][$slot], 'sticky' => 0];
+            $modules[$module] = [
+                'activated' => (int) !empty($INST_MODULES[$type][$slot]),
+                'sticky'    => 0,
+            ];
         }
         $data['modules'] = json_encode($modules);
 
@@ -306,7 +309,7 @@ class SemClass implements ArrayAccess
      */
     public function isModuleAllowed($modulename)
     {
-        return !$this->data['modules'][$modulename]
+        return !isset($this->data['modules'][$modulename])
             || !$this->data['modules'][$modulename]['sticky']
             ||  $this->data['modules'][$modulename]['activated'];
     }
@@ -318,7 +321,8 @@ class SemClass implements ArrayAccess
      */
     public function isModuleMandatory($module)
     {
-        return $this->data['modules'][$module]['sticky']
+        return isset($this->data['modules'][$module])
+            && $this->data['modules'][$module]['sticky']
             && $this->data['modules'][$module]['activated'];
     }
 
diff --git a/lib/classes/Seminar.class.php b/lib/classes/Seminar.class.php
index 337eea6..736f677 100644
--- a/lib/classes/Seminar.class.php
+++ b/lib/classes/Seminar.class.php
@@ -72,7 +72,11 @@ class Seminar
             if ($refresh_cache) {
                 self::$seminar_object_pool[$id] = null;
             }
-            if (is_object(self::$seminar_object_pool[$id]) && self::$seminar_object_pool[$id]->getId() == $id) {
+            if (
+                isset(self::$seminar_object_pool[$id])
+                && is_object(self::$seminar_object_pool[$id])
+                && self::$seminar_object_pool[$id]->getId() == $id
+            ) {
                 return self::$seminar_object_pool[$id];
             } else {
                 self::$seminar_object_pool[$id] = new Seminar($id);
diff --git a/lib/classes/SeminarCategories.class.php b/lib/classes/SeminarCategories.class.php
index fdb955e..732e5a3 100644
--- a/lib/classes/SeminarCategories.class.php
+++ b/lib/classes/SeminarCategories.class.php
@@ -32,7 +32,8 @@
 // Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 // +---------------------------------------------------------------------------+
 
-class SeminarCategories {
+class SeminarCategories
+{
 
     private static $seminar_categories = [];
 
@@ -45,10 +46,11 @@ class SeminarCategories {
      * @param String $id
      * @return Array
      */
-    public static function Get($id){
-        if(is_null(self::$seminar_categories[$id])){
+    public static function Get($id)
+    {
+        if (!isset(self::$seminar_categories[$id])){
             $cat = new SeminarCategories($id);
-            if($cat->id !== false) {
+            if ($cat->id !== false) {
                 self::$seminar_categories[$id] = $cat;
             } else {
                 self::$seminar_categories[$id] = false;
diff --git a/lib/classes/Smiley.php b/lib/classes/Smiley.php
index 803a5f4..8d37e4f 100644
--- a/lib/classes/Smiley.php
+++ b/lib/classes/Smiley.php
@@ -224,7 +224,7 @@ class Smiley
      */
     public static function getShort()
     {
-        if (class_exists('DBManager') && !$GLOBALS['SMILEY_NO_DB']) {
+        if (class_exists('DBManager') && empty($GLOBALS['SMILEY_NO_DB'])) {
             if (self::$shortnames === null) {
                 $query = "SELECT short_name, smiley_name FROM smiley WHERE short_name != ''";
                 self::$shortnames = DBManager::get()->query($query)->fetchGrouped(PDO::FETCH_COLUMN);
diff --git a/lib/classes/StudipSemSearch.class.php b/lib/classes/StudipSemSearch.class.php
index 4aef596..ebe3309 100644
--- a/lib/classes/StudipSemSearch.class.php
+++ b/lib/classes/StudipSemSearch.class.php
@@ -173,6 +173,7 @@ class StudipSemSearch {
     }
 
     function getFormEnd(){
+        $ret = '';
         if ($this->search_sem_class != 'all'){
             $ret = $this->form->getHiddenField('category',$this->search_sem_class);
         }
diff --git a/lib/classes/StudipSemTree.class.php b/lib/classes/StudipSemTree.class.php
index ecdc393..dba2fa2 100644
--- a/lib/classes/StudipSemTree.class.php
+++ b/lib/classes/StudipSemTree.class.php
@@ -37,7 +37,7 @@ class StudipSemTree extends TreeAbstract
         if (isset($args['sem_number']) ){
             $this->sem_number = array_map('intval', $args['sem_number']);
         }
-        if ($args['sem_status']){
+        if (!empty($args['sem_status'])) {
             $this->sem_status = array_map('intval', $args['sem_status']);
         } else {
             foreach ($GLOBALS['SEM_CLASS'] as $key => $value){
diff --git a/lib/classes/StudipSemTreeViewSimple.class.php b/lib/classes/StudipSemTreeViewSimple.class.php
index fee30ab..891d498 100644
--- a/lib/classes/StudipSemTreeViewSimple.class.php
+++ b/lib/classes/StudipSemTreeViewSimple.class.php
@@ -75,7 +75,7 @@ class StudipSemTreeViewSimple
                         <div class="sem-path">'.
                             '<div class="sem-path-dir">'.
                                 $this->getSemPath($start_id);
-                    echo 
+                    echo
                         '</div>
                         <div class="sem_path_info">
                             <div class="sem_path_title">'.
@@ -143,7 +143,8 @@ class StudipSemTreeViewSimple
                 <td class="table_row_even kids-tree-row" align="left" valign="top">
                     <ul class="semtree">';
         for ($i = 0; $i < $num_kids; ++$i){
-            if ($this->start_item_id != 'root') {
+            $num_entries = 0;
+            if ($this->start_item_id !== 'root') {
             $num_entries = $this->tree->getNumEntries($kids[$i],true);
                 $num_all_entries += $num_entries;
             }
diff --git a/lib/classes/TreeAbstract.class.php b/lib/classes/TreeAbstract.class.php
index b06cbcd..a23c494 100644
--- a/lib/classes/TreeAbstract.class.php
+++ b/lib/classes/TreeAbstract.class.php
@@ -78,7 +78,7 @@ class TreeAbstract {
     * @access private
     * @var array    $tree_num_childs
     */
-    var $tree_num_childs = [];
+    private $tree_num_childs = [];
 
     var $index_offset = 0;
 
@@ -94,7 +94,7 @@ class TreeAbstract {
     */
     public static function GetInstance($class_name, $args = null, $invalidate_cache = false)
     {
-        static $tree_instance;
+        static $tree_instance = [];
 
         if ($args){
             $class_hash = $class_name . "_" . md5(serialize($args));
@@ -112,7 +112,7 @@ class TreeAbstract {
         } else {
             $class_hash = $class_name;
         }
-        if (!is_object($tree_instance[$class_hash]) || $invalidate_cache){
+        if (!isset($tree_instance[$class_hash]) || $invalidate_cache){
             $tree_instance[$class_hash] = new $class_name($args);
         }
 
@@ -162,7 +162,13 @@ class TreeAbstract {
         $this->tree_data[$item_id]["priority"] = $priority;
         $this->tree_data[$item_id]["name"] = $name;
         $this->tree_childs[$parent_id][] = $item_id;
-        ++$this->tree_num_childs[$parent_id];
+
+        if (!isset($this->tree_num_childs[$parent_id])) {
+            $this->tree_num_childs[$parent_id] = 1;
+        } else {
+            $this->tree_num_childs[$parent_id] += 1;
+        }
+
         return;
     }
 
diff --git a/lib/classes/helpbar/Helpbar.php b/lib/classes/helpbar/Helpbar.php
index d2161fa..1f17c14 100644
--- a/lib/classes/helpbar/Helpbar.php
+++ b/lib/classes/helpbar/Helpbar.php
@@ -31,9 +31,9 @@ class Helpbar extends WidgetContainer
         $route        = get_route();
         $help_content = HelpContent::getContentByRoute();
         foreach ($help_content as $row) {
-            $this->addPlainText($row['label'] ?: '',
+            $this->addPlainText($row['label'] ?? '',
                                 $this->interpolate($row['content'], $this->variables),
-                                $row['icon'] ? Icon::create($row['icon'], 'info_alt') : null,
+                                $row['icon'] ?? null ? Icon::create($row['icon'], 'info_alt') : null,
                                 URLHelper::getURL('dispatch.php/help_content/edit/'.$row['content_id'], ['from' => $route]),
                                 URLHelper::getURL('dispatch.php/help_content/delete/'.$row['content_id'], ['from' => $route]));
         }
diff --git a/lib/classes/searchtypes/SearchType.class.php b/lib/classes/searchtypes/SearchType.class.php
index e0914dc..cd69a55 100644
--- a/lib/classes/searchtypes/SearchType.class.php
+++ b/lib/classes/searchtypes/SearchType.class.php
@@ -23,6 +23,7 @@
  */
 abstract class SearchType
 {
+     public $extendedLayout = false;
 
     /**
      * title of the search like "search for courses" or just "courses"
diff --git a/lib/classes/sidebar/SelectWidget.php b/lib/classes/sidebar/SelectWidget.php
index 7893559..42bbf35 100644
--- a/lib/classes/sidebar/SelectWidget.php
+++ b/lib/classes/sidebar/SelectWidget.php
@@ -28,6 +28,8 @@ class SelectWidget extends SidebarWidget
         $this->setMultiple($multiple);
 
         $this->template_variables['max_length'] = 30;
+        $this->template_variables['attributes'] = [];
+        $this->template_variables['class']      = '';
     }
 
     /**
diff --git a/lib/functions.php b/lib/functions.php
index eced4fa..acfb412 100644
--- a/lib/functions.php
+++ b/lib/functions.php
@@ -1433,7 +1433,7 @@ function get_route($route = '')
         foreach ($pieces as $index => $piece) {
             $trail .= ($trail ? '/' : '') . $piece;
             if ($dispatcher->file_exists($trail . '.php')) {
-                $route = 'dispatch.php/' . $trail . ($pieces[$index+1] ? '/' . $pieces[$index+1] : '');
+                $route = 'dispatch.php/' . $trail . (isset($pieces[$index+1]) ? '/' . $pieces[$index+1] : '');
             }
         }
     }
@@ -1462,7 +1462,7 @@ function match_route($requested_route, $current_route = '')
         return false;
     }
     // if no parameters given and base routes do match, return true
-    if (!$route_parts[1]) {
+    if (empty($route_parts[1])) {
         return true;
     }
     // extract vars and check if they are set accordingly
diff --git a/lib/models/Semester.class.php b/lib/models/Semester.class.php
index 2652de8..10b312b 100644
--- a/lib/models/Semester.class.php
+++ b/lib/models/Semester.class.php
@@ -131,8 +131,10 @@ class Semester extends SimpleORMap
     public static function findAllVisible($with_before_first = true): array
     {
         return array_values(
-            array_filter(self::getAllAsArray(), function ($semester, $key) use($with_before_first) {
-                return $GLOBALS['perm']->have_perm('admin') || $semester['visible'] || ((int)$key === 0 && $with_before_first);
+            array_filter(self::getAllAsArray(), function ($semester, $key) use ($with_before_first) {
+                return $GLOBALS['perm']->have_perm('admin')
+                    || !empty($semester['visible'])
+                    || ((int)$key === 0 && $with_before_first);
             }, ARRAY_FILTER_USE_BOTH)
         );
     }
diff --git a/lib/models/SimpleORMap.class.php b/lib/models/SimpleORMap.class.php
index 7983f0c..e7e3142 100644
--- a/lib/models/SimpleORMap.class.php
+++ b/lib/models/SimpleORMap.class.php
@@ -218,7 +218,7 @@ class SimpleORMap implements ArrayAccess, Countable, IteratorAggregate
         if (isset($config['additional_fields'])) {
             foreach ($config['additional_fields'] as $a_field => $a_config) {
                 if (is_array($a_config) && !(isset($a_config['get']) || isset($a_config['set']))) {
-                    list($relation, $relation_field) = $a_config;
+                    @list($relation, $relation_field) = $a_config;
                     if (!$relation) {
                         list($relation, $relation_field) = explode('_', $a_field);
                     }
@@ -620,7 +620,7 @@ class SimpleORMap implements ArrayAccess, Countable, IteratorAggregate
         $record = new $class();
         $sql = "SELECT `$db_table`.* FROM `$thru_table`
         INNER JOIN `$db_table` ON `$thru_table`.`$thru_assoc_key` = `$db_table`.`$assoc_foreign_key`
-        WHERE `$thru_table`.`$thru_key` = ? " . $options['order_by'];
+        WHERE `$thru_table`.`$thru_key` = ? " . ($options['order_by'] ?? '');
         $db = DBManager::get();
         $st = $db->prepare($sql);
         $st->execute([$foreign_key_value]);
@@ -834,21 +834,21 @@ class SimpleORMap implements ArrayAccess, Countable, IteratorAggregate
         $field = substr($name, strlen($prefix) + 2);
         switch ($prefix) {
             case 'findone':
-                $order = $arguments[1];
+                $order = $arguments[1] ?? null;
                 $param_arr[0] =& $where;
                 $param_arr[1] = [$where_param];
                 $method = 'findonebysql';
                 break;
             case 'find':
             case 'findmany':
-                $order = $arguments[1];
+                $order = $arguments[1] ?? null;
                 $param_arr[0] =& $where;
                 $param_arr[1] = [$where_param];
                 $method = 'findbysql';
                 break;
             case 'findeach':
             case 'findeachmany':
-                $order = $arguments[2];
+                $order = $arguments[2] ?? null;
                 $param_arr[0] = $arguments[0];
                 $param_arr[1] =& $where;
                 $param_arr[2] = [$arguments[1]];
@@ -1027,7 +1027,7 @@ class SimpleORMap implements ArrayAccess, Countable, IteratorAggregate
         if (!$options['class_name']) {
             throw new Exception('Option class_name not set for relation ' . $name);
         }
-        if (!isset($options['assoc_foreign_key']) || !$options['assoc_foreign_key']) {
+        if (empty($options['assoc_foreign_key'])) {
             if ($type === 'has_many' || $type === 'has_one') {
                 $options['assoc_foreign_key'] = $this->pk[0];
             } else if ($type === 'belongs_to') {
@@ -1062,14 +1062,14 @@ class SimpleORMap implements ArrayAccess, Countable, IteratorAggregate
                 throw new Exception("For relation " . $name . " assoc_foreign_key must be a name of a column");
             }
         }
-        if (!isset($options['assoc_func']) || !$options['assoc_func']) {
+        if (empty($options['assoc_func'])) {
             if ($type !== 'has_and_belongs_to_many') {
                 $options['assoc_func'] = $options['assoc_foreign_key'] === 'id' ? 'find' : 'findBy' . $options['assoc_foreign_key'];
             } else {
                 $options['assoc_func'] = 'findThru';
             }
         }
-        if (!isset($options['foreign_key']) || !$options['foreign_key']) {
+        if (empty($options['foreign_key'])) {
             $options['foreign_key'] = 'id';
         }
         if ($options['foreign_key'] instanceof Closure) {
diff --git a/lib/navigation/BrowseNavigation.php b/lib/navigation/BrowseNavigation.php
index ea67233..ccf0697 100644
--- a/lib/navigation/BrowseNavigation.php
+++ b/lib/navigation/BrowseNavigation.php
@@ -24,7 +24,7 @@ class BrowseNavigation extends Navigation
     {
         global $user, $perm;
 
-        $courselink = false;
+        $courselink = 'dispatch.php/my_courses';
 
         // check if logged in
         if (is_object($user) && $user->id != 'nobody') {
diff --git a/lib/plugins/engine/PluginManager.class.php b/lib/plugins/engine/PluginManager.class.php
index 659126c..5737b0b 100644
--- a/lib/plugins/engine/PluginManager.class.php
+++ b/lib/plugins/engine/PluginManager.class.php
@@ -196,6 +196,7 @@ class PluginManager
                       WHERE range_id = ?";
             $statement = DBManager::get()->prepare($query);
             $statement->execute([$context]);
+
             $this->plugins_activated_cache[$context] = $statement->fetchGrouped(PDO::FETCH_COLUMN);
         }
         return isset($this->plugins_activated_cache[$context][$id]);
@@ -222,7 +223,7 @@ class PluginManager
             $statement->execute([$userId]);
             $this->plugins_activated_cache[$userId] = $statement->fetchGrouped(PDO::FETCH_COLUMN);
         }
-        $state = $this->plugins_activated_cache[$userId][$pluginId];
+        $state = $this->plugins_activated_cache[$userId][$pluginId] ?? null;
         if ($state === null) {
             $activated = (bool) Config::get()->HOMEPAGEPLUGIN_DEFAULT_ACTIVATION;
         } else {
diff --git a/public/plugins_packages/core/Forum/models/ForumVisit.php b/public/plugins_packages/core/Forum/models/ForumVisit.php
index befe116..9f91265 100644
--- a/public/plugins_packages/core/Forum/models/ForumVisit.php
+++ b/public/plugins_packages/core/Forum/models/ForumVisit.php
@@ -133,7 +133,7 @@ class ForumVisit {
             }
         }
 
-        return $visit[$seminar_id][$GLOBALS['user']->id];
+        return $visit[$seminar_id][$GLOBALS['user']->id] ?? null;
     }
 
     /**
@@ -157,6 +157,6 @@ class ForumVisit {
     static function getVisit($seminar_id)
     {
         $visit = self::getVisitDates($seminar_id);
-        return $visit['visitdate'];
+        return $visit ? $visit['visitdate'] : null;
     }
 }
diff --git a/templates/quicksearch/inputfield.php b/templates/quicksearch/inputfield.php
index db42e37..3f29d11 100644
--- a/templates/quicksearch/inputfield.php
+++ b/templates/quicksearch/inputfield.php
@@ -12,7 +12,7 @@
         foreach ($withAttributes as $attr_name => $attr_value) {
             print ' '.$attr_name.'="'.htmlReady($attr_value).'"';
         }
-        ?> id="<?= $id ?>"<?= $clear_input ?: '' ?>
+        ?> id="<?= $id ?>"<?= $clear_input ?? '' ?>
            type="text"
            value="<?= htmlReady($defaultName) ?>"
            name="<?= strpos($name, "[") === false ? $name."_parameter" : substr($name, 0, strpos($name, "["))."_parameter".substr($name, strpos($name, "[")) ?>"
diff --git a/templates/sidebar/list-widget.php b/templates/sidebar/list-widget.php
index 7cee7cd..cadbd76 100644
--- a/templates/sidebar/list-widget.php
+++ b/templates/sidebar/list-widget.php
@@ -1,12 +1,12 @@
 <ul class="<?= implode(' ', $css_classes) ?>">
 <? foreach ($elements as $index => $element): ?>
-    <? $icon = $element->icon; ?>
+    <? $icon = $element->icon ?? null; ?>
     <? if ($icon && $element instanceof LinkElement && $element->isDisabled()): ?>
         <? $icon = $icon->copyWithRole('inactive') ?>
     <? endif ?>
     <li id="<?= htmlReady($index) ?>"
         <?= $icon ? 'style="' . $icon->asCSS() .'"' : '' ?>
-        <?= $element->active ? 'class="active"' : '' ?>>
+        <?= ($element->active ?? false) ? 'class="active"' : '' ?>>
         <?= $element->render() ?>
     </li>
 <? endforeach; ?>
diff --git a/templates/sidebar/search-widget.php b/templates/sidebar/search-widget.php
index 597e574..822247a 100644
--- a/templates/sidebar/search-widget.php
+++ b/templates/sidebar/search-widget.php
@@ -1,4 +1,4 @@
-<? if ($reset_search): ?>
+<? if ($reset_search ?? false): ?>
 <div style="text-align: right;">
     <?= $reset_search ?>
 </div>
-- 
cgit v1.0