From 3759c3248b0ca775c045ec4336748a6668b3eba5 Mon Sep 17 00:00:00 2001 From: Elmar Ludwig Date: Wed, 6 Jul 2022 13:01:07 +0200 Subject: Revert "fix #887" This reverts commit be15fc8a6117c71c3d50bbd0ae8999e1c49b12ad. --- .../JsonApi/Routes/Courseware/Authority.php | 31 +----- resources/assets/stylesheets/scss/courseware.scss | 63 ++++-------- .../courseware/CoursewareAccordionContainer.vue | 11 +- .../courseware/CoursewareActionWidget.vue | 4 +- .../components/courseware/CoursewareAudioBlock.vue | 42 +------- .../courseware/CoursewareBeforeAfterBlock.vue | 111 +++++---------------- .../courseware/CoursewareBlockActions.vue | 99 ++++++++---------- .../courseware/CoursewareCanvasBlock.vue | 51 ++-------- .../components/courseware/CoursewareChartBlock.vue | 28 +----- .../components/courseware/CoursewareCodeBlock.vue | 19 +--- .../courseware/CoursewareConfirmBlock.vue | 14 +-- .../courseware/CoursewareContainerActions.vue | 54 ++-------- .../components/courseware/CoursewareDateBlock.vue | 43 ++------ .../courseware/CoursewareDefaultBlock.vue | 58 ++--------- .../courseware/CoursewareDefaultContainer.vue | 56 +---------- .../courseware/CoursewareDialogCardsBlock.vue | 24 +---- .../courseware/CoursewareDocumentBlock.vue | 67 ++++--------- .../courseware/CoursewareDownloadBlock.vue | 37 +------ .../components/courseware/CoursewareEmbedBlock.vue | 45 +-------- .../courseware/CoursewareEmptyElementBox.vue | 6 +- .../courseware/CoursewareFolderBlock.vue | 39 ++------ .../courseware/CoursewareGalleryBlock.vue | 39 +------- .../courseware/CoursewareHeadlineBlock.vue | 69 ++----------- .../courseware/CoursewareIframeBlock.vue | 62 +----------- .../courseware/CoursewareImageMapBlock.vue | 55 +++------- .../courseware/CoursewareKeyPointBlock.vue | 25 +---- .../components/courseware/CoursewareLinkBlock.vue | 29 +----- .../courseware/CoursewareStructuralElement.vue | 21 ++-- .../courseware/CoursewareTableOfContentsBlock.vue | 24 +---- .../courseware/CoursewareTabsContainer.vue | 11 +- .../courseware/CoursewareTypewriterBlock.vue | 40 ++------ .../components/courseware/CoursewareVideoBlock.vue | 56 +---------- resources/vue/components/courseware/IndexApp.vue | 15 +-- resources/vue/components/courseware/block-mixin.js | 6 -- .../vue/store/courseware/courseware.module.js | 2 +- 35 files changed, 225 insertions(+), 1131 deletions(-) diff --git a/lib/classes/JsonApi/Routes/Courseware/Authority.php b/lib/classes/JsonApi/Routes/Courseware/Authority.php index b401855..5e30a41 100755 --- a/lib/classes/JsonApi/Routes/Courseware/Authority.php +++ b/lib/classes/JsonApi/Routes/Courseware/Authority.php @@ -59,13 +59,7 @@ class Authority public static function canUpdateBlock(User $user, Block $resource) { if ($resource->isBlocked()) { - $perm = $GLOBALS['perm']->have_studip_perm( - $resource->container->structural_element->course->config->COURSEWARE_EDITING_PERMISSION, - $resource->container->structural_element->course->id, - $user->id - ); - - return $resource->getBlockerUserId() == $user->id || $perm; + return $resource->getBlockerUserId() == $user->id; } return self::canUpdateContainer($user, $resource->container); @@ -78,28 +72,7 @@ class Authority public static function canUpdateEditBlocker(User $user, $resource) { - $structural_element = null; - if ($resource instanceof Block) { - $structural_element = $resource->container->structural_element; - } - if ($resource instanceof Container) { - $structural_element = $resource->structural_element; - } - if ($resource instanceof StructuralElement) { - $structural_element = $resource; - } - - if ($structural_element === null) { - return false; - } - - $perm = $GLOBALS['perm']->have_studip_perm( - $structural_element->course->config->COURSEWARE_EDITING_PERMISSION, - $structural_element->course->id, - $user->id - ); - - return $resource->edit_blocker_id == '' || $resource->edit_blocker_id === $user->id || $perm; + return $resource->edit_blocker_id == '' || $resource->edit_blocker_id === $user->id; } public static function canShowContainer(User $user, Container $resource) diff --git a/resources/assets/stylesheets/scss/courseware.scss b/resources/assets/stylesheets/scss/courseware.scss index 52431eb..739b1d3 100755 --- a/resources/assets/stylesheets/scss/courseware.scss +++ b/resources/assets/stylesheets/scss/courseware.scss @@ -770,14 +770,6 @@ ribbon end font-weight: 700; line-height: 2em; font-size: 1.1em; - - &.cw-default-container-blocker-warning { - font-weight: 400; - } - } - - img { - vertical-align: text-bottom; } .cw-container-actions { @@ -874,6 +866,12 @@ form.cw-container-dialog-edit-form { .cw-default-block { display: flex; flex-flow: row; + .cw-default-block-invisible-info { + img { + vertical-align: text-bottom; + } + } + } .cw-content-wrapper { display: flex; @@ -908,19 +906,10 @@ form.cw-container-dialog-edit-form { padding: 4px 10px; span { - font-size: 1.1em; color: $base-color; font-weight: 700; line-height: 2em; - - &.cw-default-block-invisible-info, - &.cw-default-block-blocker-warning { - font-weight: 400; - } - } - - img { - vertical-align: text-bottom; + font-size: 1.1em; } .cw-block-actions { @@ -933,12 +922,6 @@ form.cw-container-dialog-edit-form { } } -.cw-block-edit-warning { - font-style: italic; - color: $dark-gray-color; - margin: 1em 0 0.5em 0; -} - .cw-discuss-wrapper, .cw-block-features { @@ -3098,31 +3081,23 @@ a u d i o b l o c k padding-top: 106px; } } + .cw-audio-empty { + @include background-icon(file, info, 96); + border: solid thin $content-color-40; + background-position: center 1em; + background-repeat: no-repeat; + min-height: 140px; + padding: 1em; + p { + text-align: center; + padding-top: 106px; + } + } } /* * * * * * * * * * * * * * a u d i o b l o c k e n d * * * * * * * * * * * * * */ -/* * * * * * * * * * * * * * * * * * * * -f o r m u l t i m e d i a b l o c k s -* * * * * * * * * * * * * * * * * * * */ -.cw-file-empty { - @include background-icon(file, info, 96); - border: solid thin $content-color-40; - background-position: center 1em; - background-repeat: no-repeat; - min-height: 140px; - padding: 1em; - p { - text-align: center; - padding-top: 106px; - } -} - -/* * * * * * * * * * * * * * * * * * * * * * * * -f o r m u l t i m e d i a b l o c k s e n d -* * * * * * * * * * * * * * * * * * * * * * * */ - /* * * * * * * * * * v i d e o b l o c k * * * * * * * * * * */ diff --git a/resources/vue/components/courseware/CoursewareAccordionContainer.vue b/resources/vue/components/courseware/CoursewareAccordionContainer.vue index 924a92b..5f58dc4 100755 --- a/resources/vue/components/courseware/CoursewareAccordionContainer.vue +++ b/resources/vue/components/courseware/CoursewareAccordionContainer.vue @@ -4,10 +4,9 @@ containerClass="cw-container-accordion" :canEdit="canEdit" :isTeacher="isTeacher" + @storeContainer="storeContainer" @closeEdit="initCurrentData" - @showEdit="setShowEdit" @sortBlocks="enableSort" - @storeContainer="storeContainer" >