From bcad3cd3b9305f046ef740205a6a9166f8ed3abc Mon Sep 17 00:00:00 2001
From: Moritz Strohm <strohm@data-quest.de>
Date: Mon, 5 May 2025 11:10:05 +0000
Subject: LTI 1.3a migration: set the LTI version to 1.1 for all configured
 tools and use the correct column for the launch-url of lti-tools configured
 in courses, fixes #5491

Closes #5491

Merge request studip/studip!4188
---
 db/migrations/6.0.39_add_lti13a.php | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/db/migrations/6.0.39_add_lti13a.php b/db/migrations/6.0.39_add_lti13a.php
index 0a67568..67d5560 100644
--- a/db/migrations/6.0.39_add_lti13a.php
+++ b/db/migrations/6.0.39_add_lti13a.php
@@ -42,6 +42,9 @@ class AddLti13a extends Migration
             ADD COLUMN data_protection_notes TEXT DEFAULT NULL"
         );
 
+        //All configured tools are globally configured LTI 1.1 tools at this point:
+        $db->exec("UPDATE `lti_tools` SET `lti_version` = '1.1', `range_id` = 'global'");
+
         $this->migrateLtiDataTable();
 
         $this->addConfig();
@@ -57,7 +60,7 @@ class AddLti13a extends Migration
         //Create LTI tool instances for the old LTI 1.0/1.1 tools
         //that have been configured directly in a course:
         $stmt = $db->prepare(
-            "SELECT `id`, `tool_id`, `title`, `options`
+            "SELECT `id`, `course_id`, `tool_id`, `title`, `options`
             FROM `lti_deployments`
             WHERE `tool_id` = '0'"
         );
@@ -69,11 +72,11 @@ class AddLti13a extends Migration
         );
         $create_tool_stmt = $db->prepare(
             "INSERT INTO `lti_tools`
-            (`id`, `name`, `launch_url`, `consumer_key`, `consumer_secret`,
+            (`id`, `range_id`, `name`, `launch_url`, `consumer_key`, `consumer_secret`,
             `custom_parameters`, `send_lis_person`, `lti_version`,
             `mkdate`, `chdate`)
             VALUES
-            (:id, :name, :launch_url, :consumer_key, :consumer_secret,
+            (:id, :range_id, :name, :launch_url, :consumer_key, :consumer_secret,
             :custom_parameters, :send_lis_person, '1.1',
             UNIX_TIMESTAMP(), UNIX_TIMESTAMP())"
         );
@@ -90,8 +93,9 @@ class AddLti13a extends Migration
             $new_tool_id = $new_tool_id_stmt->fetchColumn();
             $success = $create_tool_stmt->execute([
                 'id'           => $new_tool_id,
+                'range_id'     => $row['course_id'],
                 'name'         => $row['title'],
-                'launch_url'   => $options['launch_url'] ?? '',
+                'launch_url'   => $row['launch_url'] ?? '',
                 'consumer_key' => $options['consumer_key'] ?? '',
                 'consumer_secret' => $options['consumer_secret'] ?? '',
                 'custom_parameters' => $options['custom_parameters'] ?? '',
-- 
cgit v1.0