From e20569706def9444ecb979aefd439aa2a3608871 Mon Sep 17 00:00:00 2001 From: Moritz Strohm Date: Mon, 29 Sep 2025 12:59:43 +0200 Subject: Revert "ResourceRequest::convertToEventData: allow generation of event data for anonymous users" This reverts commit 6a73ae7e6f73cd52d43624d74693af9a57cd7cb5. --- lib/models/resources/ResourceRequest.php | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/models/resources/ResourceRequest.php b/lib/models/resources/ResourceRequest.php index e5eb23f..2d08ee7 100644 --- a/lib/models/resources/ResourceRequest.php +++ b/lib/models/resources/ResourceRequest.php @@ -2286,7 +2286,7 @@ class ResourceRequest extends SimpleORMap implements PrivacyObject, Studip\Calen && ($this->user_id != $user->id); } - protected function convertToEventData(array $time_intervals, ?User $user) + protected function convertToEventData(array $time_intervals, User $user) { $booking_plan_request_bg = ColourValue::find('Resources.BookingPlan.Request.Bg'); $booking_plan_request_fg = ColourValue::find('Resources.BookingPlan.Request.Fg'); @@ -2295,16 +2295,13 @@ class ResourceRequest extends SimpleORMap implements PrivacyObject, Studip\Calen $user_is_resource_autor = false; $user_is_resource_user = $this->resource->userHasPermission($user); - if ($user && $this->resource_id && $this->resource instanceof Resource) { + if ($this->resource_id && $this->resource instanceof Resource) { $user_is_resource_autor = $this->resource->userHasPermission( $user, 'autor' ); } - $request_is_editable = $user_is_resource_autor; - if ($user) { - $request_is_editable = $user_is_resource_autor || ($user->id == $this->user_id); - } + $request_is_editable = $user_is_resource_autor || ($user->id == $this->user_id); $request_api_urls = []; $request_view_urls = []; -- cgit v1.0