aboutsummaryrefslogtreecommitdiff
path: root/resources
diff options
context:
space:
mode:
authorElmar Ludwig <elmar.ludwig@uni-osnabrueck.de>2026-03-16 12:09:07 +0100
committerElmar Ludwig <elmar.ludwig@uni-osnabrueck.de>2026-03-16 12:09:07 +0100
commite9687744733f40f4290111eadeaafa4213132b32 (patch)
tree7072d3e1800efc13c1ff5e7e40d7b8e877ebf422 /resources
parent59f04b1e31bcfa663e262feef85fdf967c58a9ac (diff)
remove label wrapper for button in action menu, fixes #6361
Closes #6361 Merge request studip/studip!4821
Diffstat (limited to 'resources')
-rw-r--r--resources/assets/stylesheets/scss/actionmenu.scss9
-rw-r--r--resources/vue/components/StudipActionMenu.vue16
2 files changed, 9 insertions, 16 deletions
diff --git a/resources/assets/stylesheets/scss/actionmenu.scss b/resources/assets/stylesheets/scss/actionmenu.scss
index 9ef7c0d..decaf32 100644
--- a/resources/assets/stylesheets/scss/actionmenu.scss
+++ b/resources/assets/stylesheets/scss/actionmenu.scss
@@ -97,11 +97,11 @@ $action-menu-shadow: 2px 2px 0 var(--color--action-menu-shadow);
border-left: solid 4px transparent;
> a,
+ > button,
> label {
margin: 0;
padding: 2px 30px 2px 0;
display: block;
- align-items: center;
}
.action-menu-item-icon {
@@ -112,11 +112,10 @@ $action-menu-shadow: 2px 2px 0 var(--color--action-menu-shadow);
}
> button {
- background: transparent;
+ background-color: unset;
border: 0;
- line-height: 20px;
- margin: 0;
- padding: 3px 0;
+ text-align: left;
+ width: 100%;
}
> label,
diff --git a/resources/vue/components/StudipActionMenu.vue b/resources/vue/components/StudipActionMenu.vue
index bb189f8..db6d267 100644
--- a/resources/vue/components/StudipActionMenu.vue
+++ b/resources/vue/components/StudipActionMenu.vue
@@ -33,20 +33,14 @@
<span v-else class="action-menu-no-icon"></span>
{{ item.label }}
</a>
- <label v-else-if="item.icon" class="undecorated" v-on="linkEvents(item)" tabindex="0">
- <studip-icon :shape="item.icon"
- :name="item.name"
+ <button v-else :name="item.name" v-bind="item.attributes" v-on="linkEvents(item)">
+ <studip-icon v-if="item.icon"
+ :shape="item.icon"
class="action-menu-item-icon"
- v-bind="item.attributes"
/>
+ <span v-else class="action-menu-no-icon"></span>
{{ item.label }}
- </label>
- <template v-else>
- <span class="action-menu-no-icon"></span>
- <button :name="item.name" v-bind="item.attributes" v-on="linkEvents(item)">
- {{ item.label }}
- </button>
- </template>
+ </button>
</li>
</ul>
</div>