ensure data is present before using it in Shib auth plugin, fixes #4616

Closes #4616

Merge request studip/studip!3429

1 files changed, 8 insertions, 6 deletions

diff --git a/lib/classes/auth_plugins/StudipAuthShib.php b/lib/classes/auth_plugins/StudipAuthShib.php
index 5548e92..f18f0c1 100644
--- a/lib/classes/auth_plugins/StudipAuthShib.php
+++ b/lib/classes/auth_plugins/StudipAuthShib.php
@@ -42,12 +42,14 @@ class StudipAuthShib extends StudipAuthSSO
 
             $this->userdata = json_decode($auth, true);
 
-            if ($this->username_attribute !== 'username') {
-                $this->userdata['username'] = $this->userdata[$this->username_attribute];
-            }
-            if (isset($this->local_domain)) {
-                $this->userdata['username'] =
-                    str_replace('@' . $this->local_domain, '', $this->userdata['username']);
+            if ($this->userdata) {
+                if ($this->username_attribute !== 'username') {
+                    $this->userdata['username'] = $this->userdata[$this->username_attribute];
+                }
+                if (isset($this->local_domain)) {
+                    $this->userdata['username'] =
+                        str_replace('@' . $this->local_domain, '', $this->userdata['username']);
+                }
             }
         }
     }