use correct way to find help tour author user, fixes #5709

Closes #5709

Merge request studip/studip!4342

1 files changed, 8 insertions, 5 deletions

diff --git a/lib/models/HelpTour.php b/lib/models/HelpTour.php
index e3704d7..70cb4df 100644
--- a/lib/models/HelpTour.php
+++ b/lib/models/HelpTour.php
@@ -72,11 +72,14 @@ class HelpTour extends SimpleORMap
             'on_delete'         => 'delete',
             'on_store'          => 'store',
         ];
-        $config['has_one']['author'] = [
-            'class_name'  => User::class,
-            'foreign_key' => 'author_email',
-            'assoc_func'  => 'findOneByEmail',
-        ];
+
+        $config['additional_fields']['author']['get'] = function (HelpTour $tour): ?User {
+            if (!$tour->author_email) {
+                return null;
+            }
+
+            return User::findOneByEmail($tour->author_email);
+        };
 
         $config['registered_callbacks']['before_store'][] = 'cbUpdateStudipVersion';