add index and set correct for auth_user_md5.matriculation_number, fixes #4577

Closes #4577

Merge request studip/studip!3392

1 files changed, 10 insertions, 0 deletions

diff --git a/lib/models/User.php b/lib/models/User.php
index 8e52589..18ab436 100644
--- a/lib/models/User.php
+++ b/lib/models/User.php
@@ -243,6 +243,16 @@ class User extends AuthUserMd5 implements Range, PrivacyObject, Studip\Calendar\
         $config['registered_callbacks']['before_store'][] = 'cbClearCaches';
         $config['registered_callbacks']['before_store'][] = 'cbStudipLog';
 
+        // Ensure matriculation number is always set to null if empty
+        $config['registered_callbacks']['before_store'][] = function (User $user) {
+            if (
+                isset($user->matriculation_number)
+                && trim($user->matriculation_number) === ''
+            ) {
+                $user->matriculation_number = null;
+            }
+        };
+
         $info = new UserInfo();
         $info_meta = $info->getTableMetadata();
         foreach ($info_meta ['fields'] as $field => $meta) {