fix php8 warnings, fixes #1679

Closes #1679

Merge request studip/studip!1084

1 files changed, 9 insertions, 4 deletions

diff --git a/lib/classes/ModulesNotification.class.php b/lib/classes/ModulesNotification.class.php
index ae86645..888052a 100644
--- a/lib/classes/ModulesNotification.class.php
+++ b/lib/classes/ModulesNotification.class.php
@@ -41,13 +41,18 @@ class ModulesNotification
     public $registered_notification_modules = [];
     public $subject;
 
-    function __construct ()
+    public function __construct ()
     {
         foreach (MyRealmModel::getDefaultModules() as $id => $module) {
-            if (!is_object($module)) continue;
+            if (!is_object($module)) {
+                continue;
+            }
+
+            $metadata = $module->getMetadata();
+
             $this->registered_notification_modules[$id] = [
-                'icon' => $module->getMetadata()['icon'],
-                'name' => $module->getMetadata()['displayname'] ?: $module->getPluginName()
+                'icon' => $metadata['icon'],
+                'name' => !empty($metadata['displayname'])  ? $metadata['displayname'] : $module->getPluginName(),
             ];
             if ($module instanceof CoreOverview) {
                 $this->registered_notification_modules[$id]['name'] = _("Ankündigungen");