Merge branch 'main' into issue-3911issue-3911

4 files changed, 5 insertions, 6 deletions

diff --git a/app/views/institute/extern/extern_config/persondetails.php b/app/views/institute/extern/extern_config/persondetails.php
index 311551d..897703d 100644
--- a/app/views/institute/extern/extern_config/persondetails.php
+++ b/app/views/institute/extern/extern_config/persondetails.php
@@ -85,7 +85,7 @@
             <select class="nested-select" name="semclass[]" multiple>
                 <? foreach ($GLOBALS['SEM_CLASS'] as $key => $sem_class) : ?>
                     <? if ($sem_class['show_browse']) : ?>
-                        <option value="<?= $key ?>"<?= in_array($key, $page->semclass) ? ' selected' : '' ?>>
+                        <option value="<?= $key ?>"<?= in_array($key, $page->semclass ?? []) ? ' selected' : '' ?>>
                             <?= htmlReady($sem_class['name']) ?>
                         </option>
                     <? endif ?>
diff --git a/app/views/institute/extern/index.php b/app/views/institute/extern/index.php
index 2fdf31e..a93d969 100644
--- a/app/views/institute/extern/index.php
+++ b/app/views/institute/extern/index.php
@@ -22,7 +22,7 @@ else : ?>
             </h1>
         </header>
         <? foreach ($config_types as $type_id => $config_type): ?>
-            <? if ($configs[$type_id]) : ?>
+            <? if (!empty($configs[$type_id])) : ?>
                 <article id="<?= $type_id ?>" <? if (Request::option('open_type') === $type_id) echo 'class="open"'; ?>>
                     <header>
                         <h1>
diff --git a/app/views/institute/extern/upload.php b/app/views/institute/extern/upload.php
index 92b2894..675f31a 100644
--- a/app/views/institute/extern/upload.php
+++ b/app/views/institute/extern/upload.php
@@ -16,7 +16,7 @@
             <div style="font-size: smaller;">
                 (<?= _('Ohne Angabe wird der Name aus den importierten Daten genommen.') ?>)
             </div>
-            <input type="text" name="config_name" value="<?= htmlReady($config_name) ?>">
+            <input type="text" name="config_name" value="<?= htmlReady($config_name ?? '') ?>">
         </label>
         <label>
             <?= _('Konfigurationsdatei') ?>
diff --git a/app/views/institute/overview/index.php b/app/views/institute/overview/index.php
index cb347b0..53b66a8 100644
--- a/app/views/institute/overview/index.php
+++ b/app/views/institute/overview/index.php
@@ -50,19 +50,18 @@
 </article>
 
 <?= $news ?>
-<?= $evaluations ?>
 <?= $questionnaires ?>
 
 <?
 // display plugins
-$plugins = PluginEngine::getPlugins('StandardPlugin', $institute_id);
+$plugins = PluginEngine::getPlugins(StandardPlugin::class, $institute_id);
 $layout = $GLOBALS['template_factory']->open('shared/index_box');
 
 foreach ($plugins as $plugin) {
     $template = $plugin->getInfoTemplate($institute_id);
 
     if ($template) {
-        echo $template->render(NULL, $layout);
+        echo $template->render(layout: $layout);
         $layout->clear_attributes();
     }
 }