relocate stud.ip trails files, fixes #4105

Closes #4105

Merge request studip/studip!2936

11 files changed, 8 insertions, 23 deletions

diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index d28b92b..9f3f8c6 100644
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -19,6 +19,12 @@
 - Die `MembersModel.php` wurde entfernt ([Issue #3811](https://gitlab.studip.de/studip/studip/-/issues/3811))
 - Die `admission.inc.php` wurde entfernt. ([Issue #3812](https://gitlab.studip.de/studip/studip/-/issues/3812))
 - Die Methoden `CronjobScheduler::scheduleOnce()` sowie `CronjobTask::scheduleOnce()` wurden ersatzlos entfernt. ([Issue #4078](https://gitlab.studip.de/studip/studip/-/issues/4078))
+- Die folgenden Klassen wurden innerhalb von Stud.IP verschoben. Da sie über den Autoloader geladen werden, kann jedes manuelle Einbinden ersatzlos entfernt werden. ([Issue #4105](https://gitlab.studip.de/studip/studip/-/issues/4105))
+  - `AuthenticatedController`
+  - `PluginController`
+  - `StudipController`
+  - `StudipControllerPropertiesTrait`
+  - `StudipResponse`
 
 ## Security related issues
 
diff --git a/app/controllers/admin/install.php b/app/controllers/admin/install.php
index 0054445..9ede078 100644
--- a/app/controllers/admin/install.php
+++ b/app/controllers/admin/install.php
@@ -1,5 +1,5 @@
 <?php
-require_once __DIR__ . '/../studip_controller_properties_trait.php';
+require_once __DIR__ . '/../../../lib/classes/StudipControllerPropertiesTrait.php';
 
 class Admin_InstallController extends Trails_Controller
 {
diff --git a/app/controllers/loncapa.php b/app/controllers/loncapa.php
index 3119178..41331b6 100644
--- a/app/controllers/loncapa.php
+++ b/app/controllers/loncapa.php
@@ -1,6 +1,4 @@
 <?php
-require_once 'app/controllers/authenticated_controller.php';
-
 class LoncapaController extends AuthenticatedController
 {
     public function enter_action()
diff --git a/app/controllers/notifications.php b/app/controllers/notifications.php
index b206df1..dc31aab 100644
--- a/app/controllers/notifications.php
+++ b/app/controllers/notifications.php
@@ -13,9 +13,6 @@
  * @since       3.0
  */
 
-require_once 'app/controllers/authenticated_controller.php';
-
-
 class NotificationsController extends AuthenticatedController
 {
     /**
diff --git a/lib/bootstrap-autoload.php b/lib/bootstrap-autoload.php
index 6f3f4a7..3a767c1 100644
--- a/lib/bootstrap-autoload.php
+++ b/lib/bootstrap-autoload.php
@@ -76,18 +76,6 @@ StudipAutoloader::addClassLookup(
     $trails_classes,
     'vendor/trails/trails.php'
 );
-StudipAutoloader::addClassLookup(
-    'StudipController',
-    'app/controllers/studip_controller.php'
-);
-StudipAutoloader::addClassLookup(
-    'AuthenticatedController',
-    'app/controllers/authenticated_controller.php'
-);
-StudipAutoloader::addClassLookup(
-    'PluginController',
-    'app/controllers/plugin_controller.php'
-);
 
 // Vendor
 StudipAutoloader::addClassLookups([
diff --git a/app/controllers/authenticated_controller.php b/lib/classes/AuthenticatedController.php
index e051ffa..e051ffa 100644
--- a/app/controllers/authenticated_controller.php
+++ b/lib/classes/AuthenticatedController.php
diff --git a/app/controllers/plugin_controller.php b/lib/classes/PluginController.php
index d57a90d..d57a90d 100644
--- a/app/controllers/plugin_controller.php
+++ b/lib/classes/PluginController.php
diff --git a/app/controllers/studip_controller.php b/lib/classes/StudipController.php
index 9e238a1..ae316c1 100644
--- a/app/controllers/studip_controller.php
+++ b/lib/classes/StudipController.php
@@ -1,6 +1,6 @@
 <?php
 /*
- * studip_controller.php - studip controller base class
+ * StudipController.php - studip controller base class
  * Copyright (c) 2009  Elmar Ludwig
  *
  * This program is free software; you can redistribute it and/or
@@ -13,9 +13,6 @@ use PhpOffice\PhpSpreadsheet\Spreadsheet;
 use PhpOffice\PhpSpreadsheet\Writer\Csv;
 use PhpOffice\PhpSpreadsheet\Writer\Xlsx;
 
-require_once 'studip_controller_properties_trait.php';
-require_once 'studip_response.php';
-
 /**
  * @property StudipResponse $response
  */
diff --git a/app/controllers/studip_controller_properties_trait.php b/lib/classes/StudipControllerPropertiesTrait.php
index 4e906fa..4e906fa 100644
--- a/app/controllers/studip_controller_properties_trait.php
+++ b/lib/classes/StudipControllerPropertiesTrait.php
diff --git a/app/controllers/studip_response.php b/lib/classes/StudipResponse.php
index 1c15326..1c15326 100644
--- a/app/controllers/studip_response.php
+++ b/lib/classes/StudipResponse.php
diff --git a/tests/unit/_bootstrap.php b/tests/unit/_bootstrap.php
index 2216111..e5299a6 100644
--- a/tests/unit/_bootstrap.php
+++ b/tests/unit/_bootstrap.php
@@ -60,7 +60,6 @@ StudipAutoloader::addAutoloadPath('lib/plugins/engine');
 StudipAutoloader::addAutoloadPath('lib/plugins/core');
 StudipAutoloader::addAutoloadPath('lib/plugins/db');
 
-StudipAutoloader::addClassLookup('StudipController', 'app/controllers/studip_controller.php');
 $trails_classes = [
     'Trails_Dispatcher', 'Trails_Response', 'Trails_Controller',
     'Trails_Inflector', 'Trails_Flash',