fix access to free courses and restore navigation item, fixes #6248

Closes #6248

Merge request studip/studip!4730

2 files changed, 3 insertions, 11 deletions

diff --git a/lib/navigation/CourseNavigation.php b/lib/navigation/CourseNavigation.php
index d4c7919..64689f3 100644
--- a/lib/navigation/CourseNavigation.php
+++ b/lib/navigation/CourseNavigation.php
@@ -41,9 +41,7 @@ class CourseNavigation extends Navigation
 
         parent::__construct($coursetext, $courselink);
 
-        if (User::findCurrent()) {
-            $this->setImage(Icon::create('seminar', Icon::ROLE_NAVIGATION, ['title' => $courseinfo]));
-        }
+        $this->setImage(Icon::create('seminar', Icon::ROLE_NAVIGATION, ['title' => $courseinfo]));
     }
 
     /**
diff --git a/lib/plugins/engine/PluginEngine.php b/lib/plugins/engine/PluginEngine.php
index 599b4f2..5c7bad5 100644
--- a/lib/plugins/engine/PluginEngine.php
+++ b/lib/plugins/engine/PluginEngine.php
@@ -43,6 +43,7 @@ class PluginEngine
         self::getPlugins(HomepagePlugin::class);
 
         $context_id = Context::getId();
+
         // load course plugins
         if ($context_id) {
             $modules = self::getPlugins(StudipModule::class, $context_id);
@@ -51,14 +52,7 @@ class PluginEngine
             foreach ($modules as $module) {
                 $tabs = $module->getTabNavigation($context_id);
 
-                if (!$tabs || !$navigation) {
-                    continue;
-                }
-
-                $has_perm = $GLOBALS['perm']->get_studip_perm($context_id);
-                $is_core = $module instanceof CoreOverview;
-
-                if ($has_perm || (!$has_perm && $is_core)) {
+                if ($navigation && $tabs) {
                     $navigation->addToolNavigation($module->getPluginId(), $tabs);
                 }
             }