aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan-Hendrik Willms <tleilax+studip@gmail.com>2026-02-27 15:42:04 +0100
committerJan-Hendrik Willms <tleilax+studip@gmail.com>2026-02-27 15:43:38 +0100
commitb1bf80e3dbf1a20b790c4345f653e57aba2290ce (patch)
tree751b6fc0f18bf9d5a2324817ff20bcaf1500b6f0
parent426e8e18232bccc01cc89d9a7f4fe09666a7b094 (diff)
fix errors from 04b81334
-rw-r--r--app/controllers/course/forum/discussion_types.php6
-rw-r--r--resources/vue/apps/forum/discussions/Show.vue6
-rw-r--r--resources/vue/apps/forum/discussions_types/Edit.vue1
3 files changed, 6 insertions, 7 deletions
diff --git a/app/controllers/course/forum/discussion_types.php b/app/controllers/course/forum/discussion_types.php
index f350991..035ea38 100644
--- a/app/controllers/course/forum/discussion_types.php
+++ b/app/controllers/course/forum/discussion_types.php
@@ -29,7 +29,7 @@ class Course_Forum_DiscussionTypesController extends AuthenticatedController
$this->discussion_types = DiscussionType::findBySQL("TRUE ORDER BY mkdate DESC");
}
- public function edit_action(?DiscussionType $discussion_type = null): void
+ public function edit_action(?DiscussionType $discussionType = null): void
{
if ($discussionType->isNew()) {
PageLayout::setTitle(_('Neuen Diskussionstyp anlegen'));
@@ -54,12 +54,12 @@ class Course_Forum_DiscussionTypesController extends AuthenticatedController
Studip\VueApp::create('forum/discussions_types/Edit')
->withProps([
'icons' => array_unique($icons),
- 'discussion_type' => $discussion_type->toRawArray()
+ 'discussion_type' => $discussionType->toRawArray()
])
);
}
- public function save_action(?DiscussionType $discussion_type = null): void
+ public function save_action(?DiscussionType $discussionType = null): void
{
CSRFProtection::verifyUnsafeRequest();
diff --git a/resources/vue/apps/forum/discussions/Show.vue b/resources/vue/apps/forum/discussions/Show.vue
index 9e77afa..5a166d2 100644
--- a/resources/vue/apps/forum/discussions/Show.vue
+++ b/resources/vue/apps/forum/discussions/Show.vue
@@ -123,12 +123,12 @@ onMounted(async () => {
if (urlHash === 'new-post') {
postCreateForm.value = true;
}
- jumpTo(document.getElementById(urlHash))
+ document.getElementById(urlHash).scrollIntoView({ behavior: 'instant' })
} else if (props.readIndex < posts.value.length) {
if (props.readIndex === 0) {
- jumpTo(document.getElementById('discussion_start'));
+ document.getElementById('discussion_start').scrollIntoView({ behavior: 'instant' });
} else {
- jumpTo(document.querySelector(`[data-index='${props.readIndex}']`));
+ document.querySelector(`[data-index='${props.readIndex}']`).scrollIntoView({ behavior: 'instant' });
}
}
diff --git a/resources/vue/apps/forum/discussions_types/Edit.vue b/resources/vue/apps/forum/discussions_types/Edit.vue
index ea1eeab..23ec39b 100644
--- a/resources/vue/apps/forum/discussions_types/Edit.vue
+++ b/resources/vue/apps/forum/discussions_types/Edit.vue
@@ -1,7 +1,6 @@
<script setup>
import {computed, reactive} from 'vue';
import StudipIcon from '@/vue/components/StudipIcon.vue';
-import {getDiscussionTypeStoreURL} from '@/vue/components/forum/helpers/urls';
const CSRF = STUDIP.CSRF_TOKEN;