check seats AFTER the data has been initialized, fixes #6136

Closes #6136

Merge request studip/studip!4737

1 files changed, 10 insertions, 6 deletions

diff --git a/app/controllers/course/room_requests.php b/app/controllers/course/room_requests.php
index 97622b5..a269e57 100644
--- a/app/controllers/course/room_requests.php
+++ b/app/controllers/course/room_requests.php
@@ -505,12 +505,6 @@ class Course_RoomRequestsController extends AuthenticatedController
             );
         }
 
-        // no min number of seats
-        if (empty($_SESSION[$request_id]['selected_properties']['seats']) || $_SESSION[$request_id]['selected_properties']['seats'] < 1) {
-            PageLayout::postError(_('Die Mindestanzahl der Sitzplätze muss größer als 0 sein!'));
-            $this->redirect('course/room_requests/request_find_available_properties/' . $request_id . '/1/category');
-        }
-
         $this->request_id = $request_id;
         $this->step = 3;
 
@@ -540,6 +534,16 @@ class Course_RoomRequestsController extends AuthenticatedController
             $this->toSession('selected_properties', $this->selected_properties);
         }
 
+        // no min number of seats
+        if (
+            empty($this->selected_properties['seats'])
+            || $this->selected_properties['seats'] < 1
+        ) {
+            PageLayout::postError(_('Die Mindestanzahl der Sitzplätze muss größer als 0 sein!'));
+            $this->redirect('course/room_requests/request_find_available_properties/' . $request_id . '/1/category');
+            return;
+        }
+
         $this->preparation_time = intval($this->request->preparation_time / 60);
         $this->reply_lecturers = $this->request->reply_recipients === ResourceRequest::REPLY_LECTURER;
         $this->comment = $this->request->comment;