summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-01-07Fix: check-doc warnings in pdf-miscdevVedang Manerikar
Relates to: #64
2022-01-07Install base-devel, autoconf on AppveyorVedang Manerikar
Since 6th Jan, 2022, builds on Appveyor are failing because they cannot find `autoreconf`[1][2]. This should be implemented from `base-devel`, but even with `base-devel` available the builds are failing. Adding an explicit require on `autoconf` in the hope that this is fixed. 1: https://ci.appveyor.com/project/vedang/pdf-tools/builds/42114287 2: https://ci.appveyor.com/project/vedang/pdf-tools/builds/42101965 Relates to: #68
2022-01-07fix: parameter to pdf-misc-popup-context-menuShuguang Sun
A parameter `event' is required at least for emacs 29.0. Add `_event' to pacitify compiling warning.
2022-01-06Fix: link to demo videoVedang Manerikar
2022-01-03Add Void Linux OS and package manager to autobuild scriptgoiabae
Very simple addition to the autobuild script to include the xbps package manager and Void Linux. Closes: politza#685
2022-01-03Add `display-line-numbers-mode` to Known ProblemsVedang Manerikar
Squashed commit. Author: LuisFCOliveira <67265998+LuisFCOliveira@users.noreply.github.com> Closes: politza#684
2022-01-03Fix: error when using autobuild on Gentooborgorworgor
This fixes `autobuild` failing on Gentoo if the user hasn't compiled `dev-util/pkgconf`[1]. Autobuild fails due to the removed[2] repository `dev-util/pkgconfig`. The new name is now `dev-util/pkgconf`. 1: https://packages.gentoo.org/packages/dev-util/pkgconf 2: https://www.mail-archive.com/gentoo-dev@lists.gentoo.org/msg93072.html Closes: politza#695, politza#693
2022-01-03Fix: use correct multiversion package syntax on OpenBSDTimo Myyrä
OpenBSD pkg_add(1) uses `package%version` syntax to specify which version of the package to use when there are multiple versions packaged. Use it for `autoconf` and `automake`. Closes: politza#696
2022-01-03Minor language correction: it's -> itsVedang Manerikar
The correct possessive with it is "its", not "it's". Closes: politza#689
2022-01-02Add a link to the PDF Tools Wiki to the READMEVedang Manerikar
The PDF Tools Wiki is live! The plan is to build this into a wonderful self-serve website.
2022-01-02Prepare the README for setting up a wiki siteVedang Manerikar
Clean it up a little bit more. The file, as it is in this commit, has been used for the first export to https://pdftools.wiki 🥂💥 Relates to: #38
2022-01-02Update version and mark it as 1.0.0snapshotVedang Manerikar
NonGNU ELPA updates based on the package version number. Unfortunately, 1.0.0snapshot is considered older than 1.0, so I don't expect this to update anything in NonGNU ELPA, but it is a step in the right direction.
2022-01-02Ensure usage of 'dvipng in `pdf-annot-print-annotation-latex`Vedang Manerikar
Users might have changed `org-preview-latex-default-process` from it's default of value 'dvipng. However, `pdf-tools` can only work with png files, so bind it locally to ensure that `pdf-tools` can do the right thing. Author: Visuwesh <visuwesh@tutanota.com> Squashed Commit. Closes: #58
2021-12-31Missed adding keybindings breaking change to NEWSVedang Manerikar
This is already part of v0.91 and should be mentioned in NEWS since it's a breaking change.
2021-12-31Release v0.91 🍾🥂v0.91Vedang Manerikar
This is the last release to support Emacs 24.x. Release 1.0.0 will update the minimum supported Emacs version. NEWS: ** Make changes required by newer versions of Emacs A number of changes are made to support new elisp / package changes. There is no impact of this on existing users. - Emacs 27, Emacs 28 and Emacs 29 are supported now. - Synctex 1.21 is supported now. ** Improve overall install experience Running ~M-x pdf-tools-install~ should _just work_ now. ** Add support for high-resolution displays (Retina display on Mac) Setting ~pdf-view-use-scaling~ to a non-nil value now renders crisp images on high-resolution displays.
2021-12-31Clean up installation instructions in the READMEVedang Manerikar
- Make the headings clearer - Remove repetitive instructions
2021-12-31Use `l` and `r` for backward / forward in history.Vedang Manerikar
`l` and `r` are the conventional bindings for history navigation. The previous key-bindings `B` and `N` are kept as-is for people who were used to it. This is a breaking change because `r` was previously bound to `revert-buffer`. However, `g` is also bound to `revert-buffer` and is the conventional binding for `revert` so this should be okay. Fixes: #43
2021-12-31Reset slice when auto-slice is turned offVedang Manerikar
When `pdf-view-auto-slice-minor-mode` is turned off, remove slicing and re-display the window. Fixes: #44
2021-12-31Clean up NEWS and prepare for a v0.91 releaseVedang Manerikar
Collect the major changes made from the previous release into NEWS. Update the milestones for the upcoming v1.0 release. Relates to: #33
2021-12-31Add NonGNU ELPA badge to README.orgStefan Kangas
Closes: #63
2021-12-31Clean up and re-organize the READMEVedang Manerikar
This is the first step in the process of creating a documentation site and wiki. Relates to: #38 Closes: #40
2021-12-31Fix checkdoc errors in pdf-tools lisp codeVedang Manerikar
- Add / Fix docstrings for functions. - Make punctuation changes as suggested by `checkdoc` This commit makes changes in a subset of files of `pdf-tools`. Some of the major files are still pending changes, and will be addressed in a later commit. Partially Fixes: #64
2021-12-31Indentation and code-quality fixesVedang Manerikar
- Remove :group arguments from `defcustom` declarations - `defcustom` picks up `defgroup` names from the same file, so specifying the group is not necessary - Ensure that all function-names are properly quoted using #' - Add an explicit header-option setting lexical-binding to t - Ensure that cl-check-type uses `satisfies` for filenames - Replace all `defadvice` with `advice-add` - Replace `(list ...)` patterns with `\`(...)` patterns Fixes: #62 Fixes: #32 Partially Fixes: #24
2021-12-28Ignore compilation artifactsVedang Manerikar
Improve the gitignore list to ignore auto-generated / compilation artifacts. Relates to #62
2021-11-10Adapt Emacs' easy-menu change #50Shuguang Sun
Emacs had made some change to the easy-menu system, that is, `easy-menu-define` lowers the menu-bar key automatically. Ref: https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-09/msg02038.html Closes #50 Signed-off-by: Shuguang Sun <shuguang79@qq.com>
2021-11-10Use theme background for tooltip arrowJunyuanChen
If `pdf-view-themed-minor-mode' is active, use theme background for tooltip arrow (background) instead of white.
2021-11-10fix: use POSIX standard builtin to search PATHJacob Vallejo
Rather than iterating over paths to find a given executable, use the POSIX standard builtin `command` [1]. [1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/command.html Signed-off-by: Jacob Vallejo <jake@jahkeup.com>
2021-11-10fix: handle alternative paths to shJacob Vallejo
Fixes #8 Signed-off-by: Jacob Vallejo <jake@jahkeup.com>
2021-10-04Sanitize buffer name for use as temp file prefixRoshan Shariff
Prefixes for temporary files are derived from either the file name associated with the pdf-view buffer, or the buffer name if it is not visiting a file. If the buffer name contains '/' characters, then it is not a valid file name. Clean up non-alphanumeric characters in the buffer name before using it as a temp file prefix.
2021-10-04Update Appveyor configsJeremy Meng
- Use VS 2019 image - Combine pacman install commands - For some reason, OpenSSL dlls were not copied as dependencies. Update to copy explicitly. Also remove previously workaround.
2021-05-31define-minor-mode: Remove support for obsolete pos argumentsThomas Hisch
This removes the positial arguemnt triplet from the define-minor-mode calls, because they are obsolete since Emacs<21. See the following paragraph in the help section of define-minor-mode. For backward compatibility with the Emacs<21 calling convention, the keywords of define-minor-mode can also be preceded by the obsolete triplet INIT-VALUE LIGHTER KEYMAP.
2021-05-31Explicitly pass width through `pdf-view-create-image`Illia Ostapyshyn
This is to avoid repeatedly scaling the displayed image width when applying highlighting. Fixes #19. Closes #22. As it turns out, it wasn't only `isearch` and `occur` which were broken, but everything that includes highlighting: selection and jump to annotation (`C-c C-a l SPC`) as well. The behavior was caused by passing the value of `(pdf-view-image-size)` into the highlight functions (`pdf-info-renderpage-text-regions` and `pdf-info-renderpage-highlight`) and using the result as it is, without re-adjusting the displayed image width as it's done when displaying raw pages without any highlighted elements, see [this line](https://github.com/vedang/pdf-tools/blob/df2eea87aa84711024b48b2184b1c1ca1b2d0e7b/lisp/pdf-view.el#L935) This caused the image width to be multiplied with the `frame-scale-factor` in `pdf-info-renderpage` and the width of the returned raw image to be interpreted by `create-image` as the requested width of the image as seen in the buffer. Fixed by passing the width explicitly in every call to `pdf-view-create-image`, except for [this one](https://github.com/vedang/pdf-tools/blob/df2eea87aa84711024b48b2184b1c1ca1b2d0e7b/lisp/pdf-annot.el#L1365), which seems to be responsible for latex fragment rendering.
2021-05-30Clean up the test code to check if poppler is properly installedVedang Manerikar
Create an explicit test file which can be compiled by c++. This commit should have been part of d435a40 and extends the change made there.
2021-05-30Update all the docker template filesVedang Manerikar
This work is part of the effort to fix the `test-all` Make target. When I complete all the work, I will update the relevant Circle CI scripts to run these tests as well. Note also that I personally use podman instead of docker, so I'm replacing docker with podman in the scripts. Someday, I might find a clever way to let both co-exist
2021-05-30Clean existing artifacts when executing `pdf-tools-install`Vedang Manerikar
Ensure that existing .o files are deleted properly. Fixes #16 and politza/pdf-tools#663
2021-05-30Add known conflict with sublimity packagethistle
Closes politza/pdf-tools#674
2021-05-30Update the README to mention that GNU/Linux is the supported OS.Vedang Manerikar
Closes #21
2021-05-30Use c++ instead of cc to avoid dependency reinstallVedang Manerikar
The deps have already been installed, but the cc step fails so the script doesn't realize this. Closes #17
2021-05-30Revert "`pdf-info-renderpage`: Use the width of the page as passed in."Vedang Manerikar
This reverts commit 8b2debaba240d20ac5f30a9ba076eb532a2396c7, which was introduced in an attempt to fix #13. I am now tracking this issue under #19. @iostapyshyn has confirmed that this change breaks scaling and is not the correct fix.
2021-05-30`pdf-info-renderpage`: Use the width of the page as passed in.Vedang Manerikar
`pdf-view-image-size` passes in the width of the current page to `pdf-info-renderpage` during an isearch. Use this as-is, instead of multiplying it with the `pdf-util-frame-scale-factor`. This is a potential fix for the bug raised by PR #13. I'm not sure if this was a bug earlier as well, but was masked since the code-path did not execute for `png` images. I will treat this as a temporary change until I can better understand the original reasons behind putting it in. Since I don't have access to a Mac running `emacs-mac` , I have tested it by hard-coding `pdf-util-frame-scale-factor` to 2 on my local setup, and everything seems to be working correctly.
2021-05-29Support HiDPI displays on vanilla emacsIllia Ostapyshyn
Fixes the long-standing issue of displaying pdf contents in proper resolution on retina Macs using vanilla (not a fork) emacs [1], [2] This commit squashes changes contributed by @iostapyshyn. It introduces the following changes: - Use `frame-scale-factor` to detect HiDPI displays in preference to other methods. `frame-scale-factor` is a new function introduced in Vanilla Emacs to return the scale factor of the backing store. - Allow scaling for `png` type images as well (if `pdf-view-use-scaling` is `t`), since this works well and I'm not sure why it was originally disabled. 1: politza/pdf-tools#51 2: hlissner/doom-emacs#4989 Closes #13
2021-05-25Improve naming and capitalization in READMERudolf Adamkovič
2021-05-11Fix: minor issues as found by package-lint and checkdocVedang Manerikar
2021-05-11Fix reference to free variable warning for image-mode-winprops-alist (#9)Utkarsh Singh
Fixes the following compilation warnings: Warning (comp): pdf-util.el:113:36: Warning: reference to free variable ‘image-mode-winprops-alist’ Warning (comp): pdf-util.el:114:39: Warning: assignment to free variable ‘image-mode-winprops-alist’
2021-04-11Remove travis.ymlVedang Manerikar
Travis CI is dead, long live travis CI.
2021-04-11Add CircleCI and Appveyor badges to READMEVedang Manerikar
Closes #5 :)
2021-04-11Fix: Download missing dll files separatelyVedang Manerikar
I'm making these changes based on reading through the output logs of the Appveyor code, I don't have any understanding of how mingw64 works.
2021-04-11Install cask using git-cloneVedang Manerikar
The go script is deprecated and will be removed in a few months.
2021-04-11Fix: Appveyor errors related to missing python2Vedang Manerikar
https://ci.appveyor.com/project/vedang/pdf-tools/builds/38649076 failed with `python2 not found`, which was the proposed fix in politza/pdf-tools@628 . My guess is that `python2` now needs to be explicitly installed in mingw64. This commit adds an explicit dependency on `mingw-w64-x86_64-python2` to test this. Closes politza/pdf-tools@628
2021-04-11Replace the Travis badge with a CircleCI badgeVedang Manerikar
Also, add my name as a maintainer for this library.