Indentation and code-quality fixes

- Remove :group arguments from `defcustom` declarations
  - `defcustom` picks up `defgroup` names from the same file, so
    specifying the group is not necessary
- Ensure that all function-names are properly quoted using #'
- Add an explicit header-option setting lexical-binding to t
- Ensure that cl-check-type uses `satisfies` for filenames
- Replace all `defadvice` with `advice-add`
- Replace `(list ...)` patterns with `\`(...)` patterns

Fixes: #62
Fixes: #32
Partially Fixes: #24

5 files changed, 11 insertions, 7 deletions

diff --git a/test/pdf-cache-test.el b/test/pdf-cache-test.el
index 26b7fe7..24abf6d 100644
--- a/test/pdf-cache-test.el
+++ b/test/pdf-cache-test.el
@@ -1,4 +1,4 @@
-
+;; -*- lexical-binding: t; -*-
 
 ;; * ================================================================== *
 ;; * Tests for pdf-cache.el
@@ -28,4 +28,3 @@
                     (pdf-cache--make-image 1 1 "1" nil)
                     (pdf-cache--make-image 3 1 "3" nil))))
     (should-not (pdf-cache-get-image 4 1))))
-
diff --git a/test/pdf-sync-test.el b/test/pdf-sync-test.el
index 544f99b..e1ebf72 100644
--- a/test/pdf-sync-test.el
+++ b/test/pdf-sync-test.el
@@ -1,4 +1,4 @@
-
+;; -*- lexical-binding: t; -*-
 
 ;; * ================================================================== *
 ;; * Tests for pdf-sync.el
diff --git a/test/pdf-tools-test.el b/test/pdf-tools-test.el
index 8a247e8..50674a7 100644
--- a/test/pdf-tools-test.el
+++ b/test/pdf-tools-test.el
@@ -1,4 +1,4 @@
-
+;; -*- lexical-binding: t; -*-
 
 ;; * ================================================================== *
 ;; * Tests not fitting anywhere else
diff --git a/test/pdf-util-test.el b/test/pdf-util-test.el
index 1f468d3..71f2ce3 100644
--- a/test/pdf-util-test.el
+++ b/test/pdf-util-test.el
@@ -1,4 +1,4 @@
-
+;; -*- lexical-binding: t; -*-
 
 ;; * ================================================================== *
 ;; * Tests for pdf-util.el
diff --git a/test/test-helper.el b/test/test-helper.el
index 0b6673d..da01765 100644
--- a/test/test-helper.el
+++ b/test/test-helper.el
@@ -1,4 +1,4 @@
-;;; test-helper --- Test helper for pdf-tools
+;;; test-helper --- Test helper for pdf-tools  -*- lexical-binding: t; -*-
 
 ;;; Commentary:
 ;; test helper inspired from https://github.com/tonini/overseer.el/blob/master/test/test-helper.el
@@ -16,7 +16,7 @@
 
 (unless (and (file-exists-p pdf-tools-package)
              (string-match "\\.tar\\'" pdf-tools-package))
-  (error "Invalid tar package:" pdf-tools-package))
+  (error "Invalid tar package: %s" pdf-tools-package))
 
 (unless load-file-name
   (error "load-file-name is unset"))
@@ -99,4 +99,9 @@
 (require 'ert)
 (require 'pdf-tools)
 
+;; FIXME: Can't be compiled with the Package-Requires dependencies alone.
+;; Local Variables:
+;; no-byte-compile: t
+;; End:
+
 ;;; test-helper.el ends here