summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnders Johansson <mejlaandersj@gmail.com>2021-06-02 17:56:42 +0200
committerAnders Johansson <mejlaandersj@gmail.com>2021-06-02 18:03:39 +0200
commitc090e36485dca8c40978c37093a845101777f2ca (patch)
tree8fa77694da9829473e4d9f5dbf8ceab39607c07a
parent672d57fe5d1a1dc40143b08ae8dc0309e2e4313c (diff)
Fix bug with helm completing-read when saving attachments
Previously helm-comp-read-use-marked was bound also when completing on a directory for saving attachments (when using a prefix argument). This returned a list with the selected directory, which caused an error.
-rw-r--r--mu4e/mu4e-view-gnus.el4
1 files changed, 2 insertions, 2 deletions
diff --git a/mu4e/mu4e-view-gnus.el b/mu4e/mu4e-view-gnus.el
index 787a2eb..2b8d68c 100644
--- a/mu4e/mu4e-view-gnus.el
+++ b/mu4e/mu4e-view-gnus.el
@@ -476,7 +476,6 @@ containing commas."
(let* ((parts (mu4e~view-gather-mime-parts))
(handles '())
(files '())
- (helm-comp-read-use-marked t)
(compfn (if (and (boundp 'helm-mode) helm-mode)
#'completing-read
;; Fallback to `completing-read-multiple' with poor
@@ -490,7 +489,8 @@ containing commas."
(push fname files))))
(if files
(progn
- (setq files (funcall compfn "Save part(s): " files)
+ (setq files (let ((helm-comp-read-use-marked t))
+ (funcall compfn "Save part(s): " files))
dir (if arg (read-directory-name "Save to directory: ") mu4e-attachment-dir))
(cl-loop for (f . h) in handles
when (member f files)