| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
We need an absolute path for opening the file, but
`find-function-search-for-symbol` expects a relative path for
primitive functions.
Using the library name allows us to avoid `find-function-C-source`,
which doesn't support Rust primitives. This should fix Remacs support.
See discussion in
https://github.com/Wilfred/remacs/pull/800
|
|
Don't bother reporting about file decompression, and use proper ERT
test skipping.
|
|
|
|
|
|
Closes #139
|
|
|
|
Resolves #141
|
|
The summary given by (helpful-callable 'rename-buffer) is
rename-buffer is an interactive function without a source file.
Needless to say, this is not correct. The problem stems from
helpful--primitive-p's inability to handle advised primitive
functions.
|
|
|
|
|
|
|
|
|
|
|
|
Fixes #143
|
|
Improve helpful--key-sequence performance
|
|
Just say 'Documentation' rather than 'Function Documentation' and so
on. Now that we have a summary sentence that says 'foo is a function'
we don't need the verbose headings.
Fixes #142
|
|
This makes it a little easier to read, especially in weird cases like
Value
((((3)
4)
5
(6))
7 8 9 nil nil nil)
|
|
helpful--show-callees choked on anonymous functions
|
|
Fixes #142
|
|
Using `symbol-name` in a format string is unnecessary, since `format`
will already convert symbols to strings. Cutting it allows for
handling other types.
|
|
Currently helpful--show-callees chokes on anonymous functions
(I don't understand the finer points of button operation, so I
couldn't figure out a more elegant way to write these tests.)
|
|
|
|
Fixes #49
|
|
|
|
Fixes #120
|
|
For variables with long docstrings (e.g. company-backends) it's a pain
to scroll down to see the current value. Whilst I think this makes the
buffer ordering seem less logical, it feels more useful. We might want
to consider tweaking heading text in future.
Fixes #138
|
|
|
|
Looking up the global keycodes is expensive, so don't do it in a loop.
|
|
The former is usually a subset of the latter, so check it first.
|
|
|
|
We might want to use TAB in future for other things, perhaps
expanding/collapsing headings.
|
|
|
|
|
|
|
|
|
|
|
|
Fix repeated calls
|
|
Add an assertion to enforce this.
|
|
This saves us having to pass through 'opened'.
|
|
helpful--definition is slow, so call it just once up front and pass
the results around to the functions that need them. This is not very
elegant, but the performance increase is worth it. This also reduces
helpful's sometimes-noisy output by calling certain noisy file-opening
functions less often.
Fixes #127
|
|
callable-p comes before the let binding in the conjunction, so it's
guaranteed to be true when the let binding occurs.
This minor, unimportant change will make a more important change
easier to follow.
|
|
In future, we could explore showing the source code rather than just
saying it's a function. For now, just fix the crash.
Fixes #133.
|
|
|
|
According to the Elisp manual, a keymap can contain a binding of the
form (TYPE ITEM-NAME . BINDING). helpful wasn't checking for that
form, so it crashed for maps like smerge-mode which contain it.
The manual also mentions a few other forms, including
(TYPE ITEM-NAME HELP-STRING . BINDING). I haven't come across that,
and this fix wouldn't handle it. Personally, I'd prefer to deal with
the weird cases as they arise, as having a concrete instance gives me
more confidence that the code handles it correctly.
|
|
Fixes #129
|
|
We show the literal view by default, but provide a toggle button to
switch to the pretty view.
Fixes #122
|
|
Don't make the helpful its own parent, and add a link to the homepage.
Fixes #125
|
|
|
