Tweak undo behavior to fix #594

In v25.1, emacs changes the way undo boundaries are automatically
removed to combine commands into single undo steps. #594 is the
result of more aggresive removals of undo boundaries.

To fix this, make evil more active in inserting undo boundaries
when entering and exiting insert and replace state by creating
a boundary automatically if none exists.

A slightly different issue in #594 is that the fine option of
evil-want-fine-undo was not always working correctly. The reason
is that it removed the first undo boundary after exiting insert
state regardless of whether it made sense to do so
(i.e., regardless of whether there was a change command). This
commit removes the fine option and simplifies the meaning of the
variable to mean aggregate commands like vim or use Emacs
heuristics.

1 files changed, 4 insertions, 4 deletions

diff --git a/evil-states.el b/evil-states.el
index 2e39db4..522cb16 100644
--- a/evil-states.el
+++ b/evil-states.el
@@ -83,13 +83,13 @@ If the region is activated, enter Visual state."
    ((evil-insert-state-p)
     (add-hook 'pre-command-hook #'evil-insert-repeat-hook)
     (unless (eq evil-want-fine-undo t)
-      (evil-start-undo-step t)))
+      (evil-start-undo-step)))
    (t
     (remove-hook 'pre-command-hook #'evil-insert-repeat-hook)
     (setq evil-insert-repeat-info evil-repeat-info)
     (evil-set-marker ?^ nil t)
     (unless (eq evil-want-fine-undo t)
-      (evil-end-undo-step t (eq evil-want-fine-undo 'fine)))
+      (evil-end-undo-step))
     (when evil-move-cursor-back
       (when (or (evil-normal-state-p evil-next-state)
                 (evil-motion-state-p evil-next-state))
@@ -814,12 +814,12 @@ CORNER defaults to `upper-left'."
     (overwrite-mode 1)
     (add-hook 'pre-command-hook #'evil-replace-pre-command nil t)
     (unless (eq evil-want-fine-undo t)
-      (evil-start-undo-step t)))
+      (evil-start-undo-step)))
    (t
     (overwrite-mode -1)
     (remove-hook 'pre-command-hook #'evil-replace-pre-command t)
     (unless (eq evil-want-fine-undo t)
-      (evil-end-undo-step t))
+      (evil-end-undo-step))
     (when evil-move-cursor-back
       (evil-move-cursor-back))))
   (setq evil-replace-alist nil))