| Age | Commit message (Collapse) | Author |
|---|
|
In `test/*.el`: Provide "test/etest/etest" to `require` so Emacs can find
the file when the package is compiled.
In `*.el`: Prefer #' to quote named functions.
Use `lexical-binding` in all the remaining files.
Use lexical-binding also in `eval`.
Remove redundant let-bindings of obsolete variable
`inhibit-point-motion-hooks`.
Replace uses of `point-at-bol` and `point-at-eol`, both marked obsolete
in Emacs-29. Use `defalias` rather than `fset` to define a function.
Fix occasional incorrect uses of ' in docstrings.
Remove some redundant `:group` arguments.
Add leading `_` to unused args.
In addition to the above, a few, more specifc, tweaks:
* lisp/ess-r-mode.el (ess-offset, ess-offset-type): Strength-reduce
`eval` to `symbol-value`.
(ess-rutils-rsitesearch): Hoist the common `browse-url` out of the `if`.
* lisp/ess-r-package.el: Don't test `fboundp` before `advice-add` since
we require Emacsā„25. Don't require `shell` since `advice-add` also
works when the function is not yet defined.
* lisp/ess-r-syntax.el (ess-parser--backward): Give it a global nil
value, both to declare it as dynamically scoped and to simplify
the code. All users adjusted not to bother with `bound-and-true-p`.
(ess-node): Hoist common `gethash` out of the `if`.
* lisp/ess-sas-a.el (ess-sas-rtf-portrait, ess-sas-rtf-landscape):
Add FIXME.
* lisp/ess-sas-d.el (ess-electric-run-semicolon): Re-indent. Add FIXME.
* lisp/ess-sas-l.el (beginning-of-sas-statement): Rename statically
scoped arg to avoid conflict with dynamically scoped var.
(sas-prev-line): Make (unused) arg optional.
(ess-imenu-SAS): Use [:alpha:] and [:alnum:].
* lisp/ess-tracebug.el (ess--tb-start, ess--tb-stop):
Use `advice-add/remove` to redefine `ess-parse-errors`.
* lisp/ess.el (ess-version-string): Don't presume `point-min` is `1`.
* lisp/obsolete/ess-mouse.el (ess-mouse-me-eval-expanded):
Remove unused var `page-scommand`.
* lisp/obsolete/mouseme.el (mouse-me-get-string, mouse-me-find-grep):
Remove unnused vars `p`, `beg`, and `end`.
* test/ess-test-inf.el (ess-test-inferior-local-start-args):
Use `*proc*` rather than undocumented `*inf-buf*`.
(ess-inf-send-fn-test, ess-inf-send-cat-some.text-test): Remove unused
var `output-nowait`.
* test/ess-test-literate.el (chunk-end): Remove `defvar`.
(elt-process-next-chunk, elt-process-next-subchunk, elt-process-case)
(elt-process-code): Pass/take `chunk-end` as argument instead.
* test/ess-test-org.el (test-org-R-ouput): Remove unused var `inf-proc`.
* test/ess-test-r-utils.el (with-ess-test-file): Add FIXME.
(ess-test-sleep-while, ess-test-unwind-protect): Move before first use.
Split the bulk of the code into a function, to ease debugging, avoid
name captures, and improve error messages.
(with-r-running): Split the bulk of the code into a function.
Document the `*proc*` var. Add FIXME.
(output, face-at, token=): Add FIXME.
(output=): Remove redundant `eval`.
* test/ess-test-r.el (ess-r-inherits-prog-mode-test): Turn global
`ess-test-prog-hook` var into local `pmh-was-run`.
* test/literate/fontification.el (face-at-point): Remove unused function.
* test/literate/roxy.el (face-at-point, faces-at-point):
Remove unused functions.
|
|
|
|
|
|
Macros like `etest-deftest-r` are not compatible with `etest-update`.
Instead we use a file-local variable to provide mode configuration.
|
|
|
|
Follow-up to #1150
|
|
|
|
- Don't change process buffer and process mark
- Avoid deleting any region if closing delimiter is not found.
- Don't assume prompt is trailing. there might be new input in case of
asynchronous interruption.
- Return remaining input after closing delimiter and prompt.
|
|
Just call newline instead of newline-and-indent. electric-indent-mode
has been on since Emacs 24.4 so indentation is taken care of already
for us and this fixes a weird edge case with the interaction of
newline-and-indent with electric-pair-mode and electric-indent-mode.
Closes #1115
|
|
|
|
|
|
|
|
|
|
|
|
Instead of ordinary filter which is for background tasks.
Because the ordinary filter (currently) does not track the process
mark, a test for visible region evaluation had to be updated. The
previous output was wrong because linewise eval inserts user inputs in
the process buffer, which interacted badly with the ordinary filter.
That's why there is now an additional `+`. Before this it was inserted
after the prompt (like this: `> +`) and (confusingly) removed from the
test output along with the prompt.
|
|
Closes #1101
|
|
|
|
|
|
Closes #1025
|
|
Simplifies inferior cleanup by automatically waiting for the process
prompt and flushing the inferior buffer
|
|
|
|
|
|
Fixes #1058
|
|
Issue #725, issuecomment-431782676
|
|
|
|
Closes #1035
|
|
|
|
|
|
And add test for `ess-cycle-assign`
|
|
|
|
|
|
Closes #1013
|
|
Closes #1020
|
|
* test/ess-test-r.el (ess-test-r-help-mode): Fails locally for me
because the call to completing-read offers plot help from both "base"
and "graphics". Fix by falling back to the car of the list if Emacs is
running noninteractively. Fix test to allow for plot or plot.default.
|
|
Instead of updating the caller's buffer.
Closes #1004.
|
|
Recent versions of roxygen2 respect newlines. Since we run both new
and old (on CI) versions of roxygen2, simply remove the newlines to
fix the test.
|
|
|
|
|
|
|
|
This reverts commit 8335337e5c9c9de8bb4687d6dc85992df1267a42.
That causes travis CI to hang for some reason.
|
|
Closes #949
|
|
In case we ever fix these tests
|
|
|
|
Thanks to Marius Hofort for this bug report via the ess-help mailing
list:
I realized that in the current snapshot version of ESS (18.10.3), C-c
C-o C-o (for Roxygen function headers) does not work as expected
anymore (on macOS 10.14.5) in the following case (and others):
fun1 <- function(x) x
fun2 <- function(x) x
If the point is right before the "f" (so column 0) of "fun2", then C-c
C-o C-o puts the Roxygen header above fun1, not fun2. If the point is
anywhere else on that line, the header is put in the right place, so
right above fun2.
|
|
|
|
|
|
|
|
fix #820, fix #822, fix #854
|
|
|
|
Closes #855
Bug #891
|
