| Age | Commit message (Collapse) | Author |
|
In `test/*.el`: Provide "test/etest/etest" to `require` so Emacs can find
the file when the package is compiled.
In `*.el`: Prefer #' to quote named functions.
Use `lexical-binding` in all the remaining files.
Use lexical-binding also in `eval`.
Remove redundant let-bindings of obsolete variable
`inhibit-point-motion-hooks`.
Replace uses of `point-at-bol` and `point-at-eol`, both marked obsolete
in Emacs-29. Use `defalias` rather than `fset` to define a function.
Fix occasional incorrect uses of ' in docstrings.
Remove some redundant `:group` arguments.
Add leading `_` to unused args.
In addition to the above, a few, more specifc, tweaks:
* lisp/ess-r-mode.el (ess-offset, ess-offset-type): Strength-reduce
`eval` to `symbol-value`.
(ess-rutils-rsitesearch): Hoist the common `browse-url` out of the `if`.
* lisp/ess-r-package.el: Don't test `fboundp` before `advice-add` since
we require Emacsā„25. Don't require `shell` since `advice-add` also
works when the function is not yet defined.
* lisp/ess-r-syntax.el (ess-parser--backward): Give it a global nil
value, both to declare it as dynamically scoped and to simplify
the code. All users adjusted not to bother with `bound-and-true-p`.
(ess-node): Hoist common `gethash` out of the `if`.
* lisp/ess-sas-a.el (ess-sas-rtf-portrait, ess-sas-rtf-landscape):
Add FIXME.
* lisp/ess-sas-d.el (ess-electric-run-semicolon): Re-indent. Add FIXME.
* lisp/ess-sas-l.el (beginning-of-sas-statement): Rename statically
scoped arg to avoid conflict with dynamically scoped var.
(sas-prev-line): Make (unused) arg optional.
(ess-imenu-SAS): Use [:alpha:] and [:alnum:].
* lisp/ess-tracebug.el (ess--tb-start, ess--tb-stop):
Use `advice-add/remove` to redefine `ess-parse-errors`.
* lisp/ess.el (ess-version-string): Don't presume `point-min` is `1`.
* lisp/obsolete/ess-mouse.el (ess-mouse-me-eval-expanded):
Remove unused var `page-scommand`.
* lisp/obsolete/mouseme.el (mouse-me-get-string, mouse-me-find-grep):
Remove unnused vars `p`, `beg`, and `end`.
* test/ess-test-inf.el (ess-test-inferior-local-start-args):
Use `*proc*` rather than undocumented `*inf-buf*`.
(ess-inf-send-fn-test, ess-inf-send-cat-some.text-test): Remove unused
var `output-nowait`.
* test/ess-test-literate.el (chunk-end): Remove `defvar`.
(elt-process-next-chunk, elt-process-next-subchunk, elt-process-case)
(elt-process-code): Pass/take `chunk-end` as argument instead.
* test/ess-test-org.el (test-org-R-ouput): Remove unused var `inf-proc`.
* test/ess-test-r-utils.el (with-ess-test-file): Add FIXME.
(ess-test-sleep-while, ess-test-unwind-protect): Move before first use.
Split the bulk of the code into a function, to ease debugging, avoid
name captures, and improve error messages.
(with-r-running): Split the bulk of the code into a function.
Document the `*proc*` var. Add FIXME.
(output, face-at, token=): Add FIXME.
(output=): Remove redundant `eval`.
* test/ess-test-r.el (ess-r-inherits-prog-mode-test): Turn global
`ess-test-prog-hook` var into local `pmh-was-run`.
* test/literate/fontification.el (face-at-point): Remove unused function.
* test/literate/roxy.el (face-at-point, faces-at-point):
Remove unused functions.
|
|
|
|
It takes care of setting up eldoc depending on user settings and
versions of eldoc and Emacs.
|
|
Closes #1126
|
|
Closes #1084
|
|
|
|
The motivation is that ESS is soon going on GNU ELPA, where
julia-mode is not available. This way people can M-x package-install
ess without needing to add MELPA to package-archives.
Co-authored-by: Stefan Monnier <monnier@iro.umontreal.ca>
|
|
This is in preparation to donate ESS to the FSF so it can be hosted
from GNU ELPA.
- Standardize all header information so that the FSF has copyright
- Move to GPLv3
|
|
|
|
|
|
Modes are now supposed to add hooks onto eldoc-documentation-functions
rather eldoc-documentation-function.
Thanks to @ShuguangSun for pointing this out.
Closes #993
|
|
|
|
|
|
It doesn't seem to be used anywhere
|
|
|
|
|
|
|
|
|
|
M-p (comint-previous-input) misbehaves unless the entire prompt is
matched. Move the setting into inferior-ess-julia-mode to minimize
reliance on the various -customize-alist variables.
Fixes #908
Bug #909
|
|
|
|
|
|
Also fix a stray quote in a docstring.
|
|
|
|
And use language-specific variables instead
|
|
* Return inferior buffer from runners
* Set buffer explicitly in roxy test
|
|
It's set in julia-mode, no need to duplicate it here.
|
|
|
|
Now e.g. M-x customize-mode should work as expected in ESS buffers.
|
|
* lisp/ess-custom.el (ess-get-help-topics-function): Remove.
* lisp/ess-gretl.el (ess-help-get-topics): New method.
(gretl-customize-alist): Remove ess-display-help-on-object-function.
* lisp/ess-help.el (ess-help-get-topics): New generic.
* lisp/ess-julia.el (ess-help-get-topics): New method.
(ess-julia-customize-alist): Remove ess-display-help-on-object-function.
* lisp/ess-r-mode.el (ess-r-help-mode): New method.
(ess-r-help-add-links): Modify to use generic.
* lisp/ess-s-lang.el (S-common-cust-alist): Remove ess-display-help-on-object-function.
(ess-help-get-topics): New method.
* lisp/ess-stata-mode.el (STA-customize-alist): Remove ess-display-help-on-object-function.
(ess-help-get-topics): New method.
|
|
Julia help buffers can contain color so we apply
ansi-color-apply-on-region to julia help buffers.
|
|
Remove variable `ess-imenu-generic-expression' and set
`imenu-generic-expression' directly in major mode setup. Also obsolete
auxiliary functions `ess-imenu-S' and `ess-imenu-R'.
|
|
See 6d6f8d4331c4d22fbdc681d706f7296941f2c0f3
Closes #797
|
|
Closes #789
|
|
Use beginning-of-defun and end-of-defun instead since they're more
generic. Major modes can set the appropriate
beginning/end-of-defun-function variables so that e.g.
ess-eval-function works out of the box.
Related to #779, #782, and closes #777
|
|
|
|
New generics ess-installed-packages and ess--load-library provide
support for ess-load-library, which is moved from ess-r-mode.el to
ess-inf.el
Closes #299
|
|
|
|
|
|
It's a holdover from S+ on windows and is no longer needed
|
|
|
|
|
|
Get rid of ess-load-extras in favor of more modular functions
|
|
|
|
|
|
|
|
|
|
julia's include doesn't do tilde expansion, so `include(~/path/to/lib)' will end up
being pwd() + ~/path/to/lib which isn't somone wants
|
|
|
|
They don't appear anywhere else in the codebase and aren't in
julia-mode.el either.
Closes #130
|
|
|