diff options
| author | Hugo Thunnissen <devel@hugot.nl> | 2024-08-30 12:24:19 +0200 |
|---|---|---|
| committer | Hugo Thunnissen <devel@hugot.nl> | 2024-08-31 13:13:55 +0200 |
| commit | 967917ceb95eec4cea1064114e136db35680d302 (patch) | |
| tree | bb59e01bc82dbea3ace6e9cfa44845292301a9b1 /phpinspect-completion.el | |
| parent | 4f85ef04a51faff7b2ad315bec501f0ccd410bdc (diff) | |
Update completion FIXME comment with current state of things
Diffstat (limited to 'phpinspect-completion.el')
| -rw-r--r-- | phpinspect-completion.el | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/phpinspect-completion.el b/phpinspect-completion.el index 5102d92..2b63db9 100644 --- a/phpinspect-completion.el +++ b/phpinspect-completion.el @@ -344,6 +344,12 @@ Returns list of `phpinspect--completion'." ;; for each completion causes hiccups due to the sheer number of completion in ;; some cases. This probably also causes the GC to kick in, making matters ;; worse. +;;;; +;; [2024-08-30 12:19] => A significant part of the performance problem seems to +;; be mitigated by the memoization of `phpinspect--type-format-display-name', +;; which is used to format/propertize return- and parameter types for +;; completions. If performance is still problematic at a later date, for example +;; on less powerful machines, consider implementing an LRU. (defun phpinspect-make-fn-completion (completion-candidate) (phpinspect--construct-completion :value (phpi-fn-name completion-candidate) |