Improve shutdown timer-drain error handling

As suggested by Stefan Monnier, use `with-demote-errors' instead of
`ignore-errors' so swallowed errors are at least logged.  Add XXX
comment explaining the undesirable behavior.

1 files changed, 5 insertions, 2 deletions

diff --git a/dape.el b/dape.el
index 2e9b9cc..e8324f1 100644
--- a/dape.el
+++ b/dape.el
@@ -2639,12 +2639,15 @@ SKIP-COMPILE is used internally for recursive calls."
 
 (defun dape--shutdown (conn)
   "Shutdown CONN and delete its jsonrpc buffers."
-  ;; Signal the process first so the sentinel fires as iter 0 in
+  ;; Signal the process first so the sentinel fires on iter 0 in
   ;; `jsonrpc-shutdown'.  Preventing the misleading sentinel warning
   ;; (DAP has no client-initiated shutdown).
   (unwind-protect
       (let ((proc (jsonrpc--process conn)))
-        (ignore-errors (accept-process-output nil 0.2)) ; pump timers before deleting
+        ;; XXX Final call for timers to run while process exists.
+        ;; May also swallow signals from non Dape owned
+        ;; timer/sentinel/filter functions.
+        (with-demote-errors "%S" (accept-process-output nil 0.2))
         (delete-process proc)
         (jsonrpc-shutdown conn t))
     (unless dape-debug